Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

hide-sm not working screen smaller than 600px in 1.0.0 RC5 #5983

Closed
windhunter89 opened this issue Nov 30, 2015 · 16 comments
Closed

hide-sm not working screen smaller than 600px in 1.0.0 RC5 #5983

windhunter89 opened this issue Nov 30, 2015 · 16 comments
Assignees
Labels
- Breaking Change needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community pr: merge ready This PR is ready for a caretaker to review type: bug
Milestone

Comments

@windhunter89
Copy link

@media (max-width: 959px) and (min-width: 600px)
.hide-sm:not(.show-sm):not(.show), .hide:not(.show-sm):not(.show) {
display: none;
}

So it make smaller 600px screen show back the div

@felipemeirelles
Copy link

+1

@felipemeirelles
Copy link

Also, layout-sm is bugged too

@felipemeirelles
Copy link

In fact all -sm aren't working

@julienpa
Copy link

julienpa commented Dec 1, 2015

Discovered the same issue today after running bower update
It is because new breakpoints has been introduced: -xs and -xl

See: 3d65dea
I hadn't seen this issue and opened a new one, related to the same thing: #5995

It should actually become the official breakpoints in the next release, i.e. -xs will become the smallest and -xl will act more or less as the previous gt-lg (although it is supposed to have a limit...)

@felipemeirelles
Copy link

The problem is, the breakpoints changed, but the directives dont, so I can't do hide-xs, can I? Also, the docs are outdated too.

@julienpa
Copy link

julienpa commented Dec 1, 2015

Yes @felipemeirelles, I have the same problem and can't use things like flex-xs...
I believe the problem (at least for me) is that my bower file is configured on ^1.0.0 for Angular Material which seems to point directly to the latest commit from master, and not to the latest release tag. You can fix this by setting the bower dependency to 1.0.0-rc5 explicitly.

@zevmo
Copy link

zevmo commented Dec 1, 2015

@felipemeirelles is correct. xs was introduced, but xs doesn't work, so no sm size is functional.

@julienpa
Copy link

julienpa commented Dec 1, 2015

@zevmo sm works, it's just not the same value anymore. xs is going to be the old sm, and now sm has the same value as the old md...etc.

@zevmo
Copy link

zevmo commented Dec 1, 2015

@julienpa You're right. I meant to say that hide-xs isn't working for me. Sorry.

@ThomasBurleson
Copy link
Contributor

@windhunter89 - where do you see this invalid/incorrect @medai query? The latest builds appear correct: https://github.com/angular/bower-material/blob/master/angular-material.css#L2798.

Our release of 1.0.0-rc6 (today), will show the breaking changes introduced on Nov 28 & 29. See the commit details here:

@ThomasBurleson
Copy link
Contributor

@julienpa - are you using the latest build from master ? If yes, please provide a CodePen that demonstrates the issue with hide-xs. Thx.

@ThomasBurleson ThomasBurleson added - Breaking Change type: bug needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community labels Dec 2, 2015
@ThomasBurleson ThomasBurleson added this to the 1.0-rc7 milestone Dec 2, 2015
@ThomasBurleson ThomasBurleson self-assigned this Dec 2, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc6, 1.0-rc7 Dec 2, 2015
@julienpa
Copy link

julienpa commented Dec 2, 2015

@ThomasBurleson I was using ^1.0.0 in my bower.json which seems to use the latest commit from master, even if it's been done after the latest tagged release. I didn't have problem with hide-xs personnally, just flex-xs that wasn't working when I tried 2 days ago.
Thanks!

@OttoDoorenbos
Copy link

@ThomasBurleson

I have the same is issues:

This doesn't work:
-div layout="row" layout-xs="column"-

When I add the class by hand it works:
-div layout="row" class="layout-xs-column"-

I'm on:
v1.0.0-rc5-master-358fd98 (.js and .css)
Chrome Browser

@ThomasBurleson
Copy link
Contributor

@Mylogin-info - Thx this is helpful. We will resolve today.

ThomasBurleson added a commit that referenced this issue Dec 2, 2015
* Refactor Layout API directive registration to iteration all known breakpoints.
* Update `layout.spec.js` tests to test all breakpoints

Fixes #5983.
@ThomasBurleson
Copy link
Contributor

@windhunter89, @Mylogin-info, @julienpa, @zevmo - Thanks for this issue report and your persistence. This revealed some important oversight(s) for xs, gt-xs, and xl breakpoints that were missing in recent Layout api changes.

The above Pull request should be merged today

@ThomasBurleson ThomasBurleson added the pr: merge ready This PR is ready for a caretaker to review label Dec 2, 2015
ThomasBurleson added a commit that referenced this issue Dec 2, 2015
* Refactor Layout API directive registration to iteration all known breakpoints.
* Update `layout.spec.js` tests to test all breakpoints

Fixes #5983.
@julienpa
Copy link

julienpa commented Dec 2, 2015

It will also fix #5995 then.
Thanks for keeping us posted @ThomasBurleson!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
- Breaking Change needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community pr: merge ready This PR is ready for a caretaker to review type: bug
Projects
None yet
Development

No branches or pull requests

6 participants