Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

datepicker: remove dependency to $mdGesture #9793

Closed
devversion opened this issue Oct 9, 2016 · 0 comments
Closed

datepicker: remove dependency to $mdGesture #9793

devversion opened this issue Oct 9, 2016 · 0 comments
Assignees
@crisbeto
Labels
has: Pull Request A PR has been created to address this issue P2: required Issues that must be fixed.
Milestone
1.1.2

Comments

@devversion
Copy link
Member

In favor of #9362 the Datepicker component should not depend on the $mdGesture service.

The datepicker right now, just uses the service to detect whether the current agent is a touch device or not.

This check can be inlined, because after #9362 nothing will have a similar check.

Notice that this is just a PR to make the integration to HammerJS easier.
@devversion devversion added the P2: required Issues that must be fixed. label Oct 9, 2016
crisbeto added a commit to crisbeto/material that referenced this issue Oct 10, 2016
@crisbeto
fix(datepicker): remove dependency on $mdGesture
5ac4520 
Removes the datepicker's dependency on `$mdGesture` by inlining the check. This is a preparation for the switch over to HammerJS.

Fixes angular#9793.
@crisbeto crisbeto added the has: Pull Request A PR has been created to address this issue label Oct 10, 2016
@crisbeto crisbeto mentioned this issue Oct 10, 2016
Merged
@ThomasBurleson ThomasBurleson modified the milestone: 1.1.2 Oct 11, 2016
jelbourn pushed a commit that referenced this issue Oct 24, 2016
@crisbeto @jelbourn
fix(datepicker): remove dependency on $mdGesture (#9803)
72b4f10 
Removes the datepicker's dependency on `$mdGesture` by inlining the check. This is a preparation for the switch over to HammerJS.

Fixes #9793.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
has: Pull Request A PR has been created to address this issue P2: required Issues that must be fixed.
Projects
None yet
Milestone
1.1.2
Development

No branches or pull requests
3 participants
@ThomasBurleson @crisbeto @devversion