-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat(gridList): adds grid-based layout #1433
Conversation
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
ed86334
to
d0fdd9f
Compare
Not exactly sure how the PR got into this state. History rewriting? |
CLAs look good, thanks! |
OK, all fixed up. |
@shyndman - what do you mean the height == 0px ? BTW - this looks GREAT! I will start the PR merge process: reviewing and testing |
@shyndman - those demos are "slicker than goose poop on a hot metal roof". #woot. |
@shyndman - I will merge and close this. Meanhwhile can you do another PR with jsDocs for the MGridTileFooter and MGridTileHeader. |
@ThomasBurleson re: height == 0px Because the grid contains only absolutely positioned elements it doesn't have have a height. I need to write some code to give it one based on the content, but I'm still figuring out the right place to plug in. |
@ThomasBurleson re: header and footer They're described in the |
@shyndman - perhaps at the end of of the |
@ThomasBurleson It needs access to the element and the rowCount to make it happen, so I think it might have to be callback provided to $mdLayout, similar to map(). |
Capture those in a bind curry wrapper On Monday, February 9, 2015, Scott Hyndman notifications@github.com wrote:
Thomas Burleson http://www.gridlinked.info |
+1 for height calculation!! |
@turkingj I'll see if I can get it in today. |
thanks @shyndman, awesome work, much appreciated... |
Still needs:
Fixes #933