Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

feat(gridList): adds grid-based layout #1433

Closed
wants to merge 1 commit into from
Closed

feat(gridList): adds grid-based layout #1433

wants to merge 1 commit into from

Conversation

shyndman
Copy link
Contributor

@shyndman shyndman commented Feb 9, 2015

Still needs:

  • Height calculation (currently grids have a height of 0px)
  • Additional styles for header/footer
  • Styles for md-button
  • Tests

Fixes #933

@ajoslin ajoslin added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Feb 9, 2015
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@shyndman shyndman changed the title Grid List feat(gridList): grid based layout for tiles, supporting rowspan/colspan and multiple height modes Feb 9, 2015
@shyndman shyndman changed the title feat(gridList): grid based layout for tiles, supporting rowspan/colspan and multiple height modes feat(gridList): adds grid-based layout Feb 9, 2015
@shyndman
Copy link
Contributor Author

shyndman commented Feb 9, 2015

Not exactly sure how the PR got into this state. History rewriting?

@googlebot
Copy link

CLAs look good, thanks!

@shyndman
Copy link
Contributor Author

shyndman commented Feb 9, 2015

OK, all fixed up.

@ThomasBurleson
Copy link
Contributor

@shyndman - what do you mean the height == 0px ? BTW - this looks GREAT! I will start the PR merge process: reviewing and testing

@ThomasBurleson
Copy link
Contributor

@shyndman - those demos are "slicker than goose poop on a hot metal roof". #woot.

@ThomasBurleson
Copy link
Contributor

@shyndman - I will merge and close this. Meanhwhile can you do another PR with jsDocs for the MGridTileFooter and MGridTileHeader.

@ThomasBurleson ThomasBurleson removed the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Feb 9, 2015
@shyndman
Copy link
Contributor Author

shyndman commented Feb 9, 2015

@ThomasBurleson re: height == 0px

Because the grid contains only absolutely positioned elements it doesn't have have a height. I need to write some code to give it one based on the content, but I'm still figuring out the right place to plug in.

@shyndman
Copy link
Contributor Author

shyndman commented Feb 9, 2015

@ThomasBurleson re: header and footer

They're described in the md-grid-tile docs. Think that's enough?

@ThomasBurleson
Copy link
Contributor

@shyndman - perhaps at the end of of the layout() function?

@shyndman
Copy link
Contributor Author

shyndman commented Feb 9, 2015

@ThomasBurleson It needs access to the element and the rowCount to make it happen, so I think it might have to be callback provided to $mdLayout, similar to map().

@ThomasBurleson
Copy link
Contributor

Capture those in a bind curry wrapper

On Monday, February 9, 2015, Scott Hyndman notifications@github.com wrote:

@ThomasBurleson https://github.com/ThomasBurleson It needs access to
the element and the rowCount to make it happen, so I think it might have to
be callback provided to $mdLayout, similar to map().


Reply to this email directly or view it on GitHub
#1433 (comment).

Thomas Burleson
Mindspace LLC

http://www.gridlinked.info
http://www.linkedin/in/ThomasBurleson
https://github.com/ThomasBurleson

@turkingj
Copy link

+1 for height calculation!!

@shyndman
Copy link
Contributor Author

@turkingj I'll see if I can get it in today.

@turkingj
Copy link

thanks @shyndman, awesome work, much appreciated...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mdGridList: Implement new md-gridlist component
5 participants