Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Fixing md-tooltip on Firefox issues #3047, #3250 and #3430 #3447

Closed
wants to merge 1 commit into from
Closed

Fixing md-tooltip on Firefox issues #3047, #3250 and #3430 #3447

wants to merge 1 commit into from

Conversation

evertonrobertoauler
Copy link

var computedStyles = $window.getComputedStyle(element[0]);

console.log(computedStyles['pointer-events'] ); // Firefox returns 'none' as string
console.log(computedStyles['pointer-events'] ); // Chrome returns an empty string ''

The problem is that hasComputedStyleValue('pointer-events','none') always returns true on Firefox and setVisible(true); is not being called.

All the tests are still passing and now the Tooltip works fine on Chrome and Firefox again.

Review on Reviewable

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@evertonrobertoauler evertonrobertoauler changed the title Fixing issues #3047, #3250 and #3430 Fixing md-tooltip on Firefox issues #3047, #3250 and #3430 Jun 25, 2015
@ThomasBurleson
Copy link
Contributor

@evertonrobertoauler - I cannot merge this without a signed CLA.

@@ -129,7 +129,7 @@ function MdTooltipDirective($timeout, $window, $$rAF, $document, $mdUtil, $mdThe
function bindEvents () {
var mouseActive = false;
var enterHandler = function() {
if (!hasComputedStyleValue('pointer-events','none')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does not make sense. The three valid pointer-events style values for any HTML element are:

  • auto
  • inherit
  • none

@ThomasBurleson
Copy link
Contributor

Closed with 6fc9212

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants