fix(autocomplete): Allow clicks inside md-not-found. #5564
Conversation
Fix bug causing the autocomplete to blur, lose focus, and hide the not found message if the user attempted to click the not found message (or a link inside of it). Fixes #5424.
| @@ -359,8 +359,8 @@ function MdAutocompleteCtrl ($scope, $element, $mdUtil, $mdConstant, $mdTheming, | |||
| * Handles input blur event, determines if the dropdown should hide. | |||
| */ | |||
| function blur () { | |||
| hasFocus = false; | |||
There was a problem hiding this comment.
@robertmesserle Can you think of any reason why the hasFocus was outside of the if statement? All tests pass after moving it and my manual testing didn't show any differences except that it fixed my bug.
There was a problem hiding this comment.
Yes, this is so that we know when the element lost focus so that we can refocus when they leave the dropdown. This was related to ie 11.
Sent from my iPhone
On Nov 4, 2015, at 3:43 PM, Topher Fangio notifications@github.com wrote:
In src/components/autocomplete/js/autocompleteController.js:
@@ -359,8 +359,8 @@ function MdAutocompleteCtrl ($scope, $element, $mdUtil, $mdConstant, $mdTheming,
* Handles input blur event, determines if the dropdown should hide.
*/
function blur () {
- hasFocus = false;
@robertmesserle Can you think of any reason why the hasFocus was outside of the if statement? All tests pass after moving it and my manual testing didn't show any differences except that it fixed my bug.—
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
I restored it:
function blur () {
hasFocus = false;
if (!noBlur) {
ctrl.hidden = shouldHide();
}
}
|
@topherfangio - what is the status of this PR ? |
|
Fixed with SHA 5ae3d4c |
Fix bug causing the autocomplete to blur, lose focus, and hide the not found message if the user attempted to click the not found message (or a link inside of it).
Fixes #5424.