This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(virtualRepeat): sets initial size for virtual repeat when the fir… #6139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -243,7 +243,7 @@ VirtualRepeatContainerController.prototype.sizeScroller_ = function(size) { | |||
| VirtualRepeatContainerController.prototype.autoShrink_ = function(size) { | |||
| var shrinkSize = Math.max(size, this.autoShrinkMin * this.repeater.getItemSize()); | |||
| if (this.autoShrink && shrinkSize !== this.size) { | |||
| if (shrinkSize < (this.originalSize || this.size)) { | |||
| if (shrinkSize < (this.originalSize || this.size) || !(this.originalSize || this.size)) { | |||
There was a problem hiding this comment.
Would it work if it was just
if (shrinkSize < (this.originalSize || this.size) || !(this.originalSize))
?
There was a problem hiding this comment.
That does have a different meaning, but the way that looks is still pretty awkward.
robertmesserle
force-pushed
the
rmesserle/virtual-repeater-sizing-fix
branch
2 times, most recently
from
bd4c15a
to
41d25fa
Compare
…st results require shrinking closes #5826
robertmesserle
force-pushed
the
rmesserle/virtual-repeater-sizing-fix
branch
from
41d25fa
to
2f5d786
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…st results require shrinking
closes #5826