feat(menu): add keyboard events and improve accessibility #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
added
in progress
kara
added
pr: needs review
and removed
in progress
| * to focus the first item when the menu is opened by the ENTER key. | ||
| * TODO: internal | ||
| */ | ||
| _focusFirstItem() { this.items.first.focus(); } |
There was a problem hiding this comment.
Personally I prefer to always have the newlines for method definitions
jelbourn
changed the title
kara
added
in progress
kara
force-pushed
the
keyboard-pr
branch
3 times, most recently
from
5a9ba46
to
0bb6e93
Compare
kara
added
pr: needs review
and removed
in progress
|
@jelbourn Comments should be addressed, and updated the keyboard behavior. |
| also adds `aria-hasPopup="true"` to the trigger element. | ||
|
|
||
| #### Keyboard events: | ||
| - <kbd>DOWN_ARROW</kbd> or <kbd>TAB</kbd>: Focus next menu item |
There was a problem hiding this comment.
Do you need to remove Tab shortcuts now?
There was a problem hiding this comment.
Yes! Good catch. Updating..
|
LGTM aside from that one comment |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds keyboard events and proper focus management to the menu.
r: @jelbourn