Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect name in express-engine ng update schematic #1533

Closed
1 of 6 tasks
jonathonadams opened this issue Mar 3, 2020 · 1 comment · Fixed by #1543
Closed
1 of 6 tasks

Incorrect name in express-engine ng update schematic #1533

jonathonadams opened this issue Mar 3, 2020 · 1 comment · Fixed by #1543

Comments

@jonathonadams
Copy link

jonathonadams commented Mar 3, 2020

🐞 Bug report

What modules are related to this issue?

  • aspnetcore-engine
  • builders
  • common
  • express-engine
  • hapi-engine
  • module-map-ngfactory-loader

Is this a regression?

Unsure, I was not using @nguniversal/express-engine prior to v9

Description

After installing @nguniversal/express-engine with ng add @nguniversal/express-engine the wrong package name is shown if you run ng update.

The package name displayed is @nguniversal/aspnetcore-engine

🔬 Minimal Reproduction

Note: to demonstrate the update when running ng update, v9.0.0 is explicitly targeted.

$ npm i -g @angular/cli

$ ng new universal-app

$ ng add @nguniversal/express-engine@9.0.0

$ ng update

The output is:

    We analyzed your package.json, there are some packages to update:

      Name                               Version                  Command to update
     --------------------------------------------------------------------------------
      @nguniversal/aspnetcore-engine     9.0.0 -> 9.0.1           ng update @nguniversal/aspnetcore-engine

🌍 Your Environment


 9.0.4
Node: 12.9.1
OS: win32 x64

Angular: 9.0.4
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... platform-server, router
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.900.4
@angular-devkit/build-angular     0.900.4
@angular-devkit/build-optimizer   0.900.4
@angular-devkit/build-webpack     0.900.4
@angular-devkit/core              9.0.4
@angular-devkit/schematics        9.0.4
@ngtools/webpack                  9.0.4
@nguniversal/builders             9.0.1
@nguniversal/common               9.0.0
@nguniversal/express-engine       9.0.0
@schematics/angular               9.0.4
@schematics/update                0.900.4
rxjs                              6.5.4
typescript                        3.7.5
webpack                           4.41.2

alan-agius4 added a commit that referenced this issue Mar 9, 2020
By default if no `packageGroupName` is provided `ng-update` will use the first item in `packageGroup` which in this case it is always `@nguniversal/aspnetcore-engine`.

With this change we set the `packageGroupName` of each package, also we remove `ng-update` from `@nguniversal/builders` as this gets updated when running `ng update` on `@nguniversal/express-engine`  or `@nguniversal/hapi-engine`.

Closes #1542 and closes #1533
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant