Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Zone.js higher than 0.6.21 breaks angular-universal https calls #484

Closed
AMar4enko opened this issue Oct 12, 2016 · 3 comments
Closed

Zone.js higher than 0.6.21 breaks angular-universal https calls #484

AMar4enko opened this issue Oct 12, 2016 · 3 comments

Comments

@AMar4enko
Copy link

Calls to https:// end up with error code: ECONNRESET, as described in angular/universal-starter#172

@JiaLiPassion
Copy link
Collaborator

This is because the EventEmitter.once is not handled properly, I have create a pull request, you can use my repository for test, https://github.com/JiaLiPassion/zone.js.git.

JiaLiPassion added a commit to JiaLiPassion/zone.js that referenced this issue Nov 9, 2016
mhevery pushed a commit that referenced this issue Nov 16, 2016
…atch. (#500)

* fix long-stack-trace zone will not render correctly when reject a promise

* fix issue #484 and #491, patch EventEmitter.once and removeAllListeners

* add event emitter once test case

* prependlistener should add listener at the beginning of the listener array.
add test cases for prepend listener and once.

* use newest fetch to test
@John0x
Copy link

John0x commented Nov 23, 2016

Any updates on this?

@JiaLiPassion
Copy link
Collaborator

This has been fixed, you can use the latest zone.js 0.7.1 to test.

mhevery pushed a commit that referenced this issue Dec 5, 2016
…tch process.nextTick, fix removeAllListeners bug (#516)

* fix long-stack-trace zone will not render correctly when reject a promise

* fix issue #484 and #491, patch EventEmitter.once and removeAllListeners

* add event emitter once test case

* prependlistener should add listener at the beginning of the listener array.
add test cases for prepend listener and once.

* use newest fetch to test

* patch process.nextTick

* restore ZoneAwareError captureStackTrace function

* move captureStackTrace test into node

* use hasOwnProperty for check captureStackTrace exist or not

* change var to const

* add process.spec.ts into node_tests.ts target

* add done in process.spec.ts

* change var to let

* add nexttick order case

* add prepareStackTrace callback to ZoneAwareError

* fix when EventEmitter removeAllListeners has no event type parameter, should remove all listeners

* change some var to let/const, remove unnecessary cancelTask call

* modify testcases

* remove typo

* use zone.scheduleMicrotask to patch process.nextTick

* forget use let/const again

* add comment to removeAllListeners patch, and remove useCapturing parameter cause it is not needed

* update fetch to 2.0.1
JiaLiPassion added a commit to JiaLiPassion/zone.js that referenced this issue Dec 6, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants