This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 408
Using webcomponentsjs polyfill makes RxJS callbacks run outside NgZone on Safari #671
Comments
@aabluedragon , thank you for posting the issue, and the reproduce repo. the reason seems to be in Safari, XMLHttpRequest define addEventListener in XMLHttpRequestEventTarget prototype without using EventTarget's. |
JiaLiPassion
added a commit
to JiaLiPassion/zone.js
that referenced
this issue
Mar 12, 2017
JiaLiPassion
added a commit
to JiaLiPassion/zone.js
that referenced
this issue
Mar 12, 2017
JiaLiPassion
added a commit
to JiaLiPassion/zone.js
that referenced
this issue
Mar 12, 2017
dist.zip |
mhevery
pushed a commit
that referenced
this issue
Mar 13, 2017
@JiaLiPassion Thanks, it works as expected 👍 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'm submitting a ... (check one with "x")
Current behavior
Including the
webcomponentsjs
polyfill versions<=0.7.24
(for usage with Polymer1paper-elements
) makes RxJS callbacks (e.g subscribe, map) execute outside NgZone.Expected behavior
RxJS callbacks should execute inside NgZone.
Minimal reproduction of the problem with instructions
<=0.7.24
(issue does not reproduce on 1.0.0-rc-6, but it can't be used with Polymer1).<script src="bower_components/webcomponentsjs/webcomponents.min.js"></script>
WebComponentsReady
event.post
, notice the callback is executed outside NgZone:I've prepared a sample project on github to demonstrate this issue: https://github.com/aabluedragon/safari-ngzone-issue
Also posted on stackoverflow: http://stackoverflow.com/q/42700937/230637
What is the motivation / use case for changing the behavior?
Usage with Polymer1 (for polymer elements, such as paper-elements).
Please tell us about your environment:
macOS Sierra 10.12.3, Webstorm, npm, Polymer1.
Angular version: 2.4.9
Browser:
Works fine on Chrome, issue happens in Safari only.
Language:
Typescript
Node (for AoT issues):
node --version
= v7.7.1The text was updated successfully, but these errors were encountered: