Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

fix(webcomponents): fix #782, fix conflicts with shadydom of webcomponents #784

Merged
merged 3 commits into from
May 19, 2017

Conversation

JiaLiPassion
Copy link
Collaborator

fix #782.

in shadydom of webcomponents, it will also patch addEventListener/removeEventListener of WindowPrototype and Node.prototype.
https://github.com/webcomponents/shadydom/blob/master/src/patch-builtins.js

It will cause those methods out of ngZone because zone.js didn't patch Node.prototype directly.
So in this PR, we have a webapis-shadydom.js.
To use this js, load them in following orders.

<script src="https://unpkg.com/@webcomponents/webcomponentsjs/webcomponents-lite.js"></script>
<script src="https://unpkg.com/zone.js/dist/zone.js"></script>
<script src="https://unpkg.com/zone.js/dist/webapis-shadydom.js"></script>

@mhevery mhevery merged commit 245f8e9 into angular:master May 19, 2017
@JiaLiPassion JiaLiPassion deleted the shadydom branch July 13, 2017 04:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebComponent Polyfill Conflicts with Angular Forms
3 participants