-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added secure store for the wallet key #21
Conversation
ce0b6ec
to
b0d7c6f
Compare
Signed-off-by: Tom Lanser <tom@devv.nl>
Signed-off-by: Tom Lanser <tom@devv.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Do we need error handling for this? Or what happens when the key can not be found when a user already has a wallet? Or is this not actually possible?
@janrxyz There will be a error when the key for the wallet is incorrect. But I'm not really sure what we want to do in that case. |
apps/expo/app/_layout.tsx
Outdated
const agent = await initializeAgent(walletKey).catch(() => { | ||
toast.show('Could not initialize agent.') | ||
}) | ||
if (!agent) return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is kind of a dead end. What does the UI look like? I think we should show at least a warning to the user like "Could not establish a secure environment. The current device is not supported." and show that indefinitely (as otherwise it will show a white screen or something?).
Also, in which case will secure store not be available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Tom Lanser <tom@devv.nl>
No description provided.