Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the ability to load plugins in config #294

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

henworth
Copy link

@henworth henworth commented Jan 8, 2022

Adds the ability to specify plugins as a list of entries in a config file. This is an alternative to the current method of supplying them as command line flags, and is written to reflect the idea posted in #251 of allowing this syntax:

- plugins:
    - dotbot-template
    - dotbot-plugins/dotbot-apt
    - missing-plugin

Given that list, and assuming only the first two plugins have been added locally, and that template was configured as such:

- template:
    - ~/.gnupg/gpg-agent.conf:
        source_file: gpg-agent.conf
        params:
          __UNAME__:
            PINENTRY_PROGRAM:
              Darwin: /usr/local/bin/pinentry-mac
              Linux: /usr/bin/pinentry-gnome3

The output when installed would contain this:

Loading plugin from dotbot-template
Loading plugin from dotbot-plugins/dotbot-apt
Loading plugin from missing-plugin
Failed to load plugin from missing-plugin
Some commands were not successfully executed
Rendering template ~/.gnupg/gpg-agent.conf

dotbot/dispatcher.py Outdated Show resolved Hide resolved
@henworth
Copy link
Author

henworth commented Apr 4, 2022

@anishathalye Not sure if this slipped through the cracks, just wanted to see if this is something that is of interest.

@anishathalye
Copy link
Owner

Thanks for bumping this. It's definitely of interest, I've just been behind in reviewing this PR. I've been stretched a bit thin recently, and my first priority for open-source is fixing bugs (in particular, this from a different project that I maintain), but right after that, I plan to review and merge this PR.

@henworth
Copy link
Author

henworth commented Apr 5, 2022

No worries at all! Completely understand and respect your need to prioritize. Thank you for responding, take all the time you need.

@henworth
Copy link
Author

This has been fixed up to account for interim changes.

@simon-bueler simon-bueler mentioned this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants