-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add typings #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @anishkny, thanks for this PR! I tried your diff in my experiment (blockprotocol/blockprotocol#447) and it worked!
The only thing I overlooked in #53 was the scope of exports. I thought playwright-test-coverage
was re-exporting everything from @playwright/test
, but it was actually just test
and expect
.
My diff suggestion should do the job.
We can consider switching back to import { devices } from "playwright-test-coverage" Direct imports from |
Co-authored-by: Alexander Kachkaev <alexander@kachkaev.ru>
Thanks for addressing my comment @anishkny, the diff LGTM! 👏 |
Shipped in v1.1.0 |
Closes #53