Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cotton Candy Theme #1129

Closed
wants to merge 1 commit into from
Closed

Cotton Candy Theme #1129

wants to merge 1 commit into from

Conversation

joelschmol
Copy link
Contributor

@joelschmol joelschmol commented Sep 20, 2023 •
edited
Loading

Screenshot_20230920-082357
Screenshot_20230920-082355
Screenshot_20230920-082344
Screenshot_20230920-082340

Cotton Candy Theme
53484f2 
feat(themes): added a new theme
@quickdesh
Copy link
Contributor

Could you add some screenshots?
It would make it easier to look into the colors.

@quickdesh
Copy link
Contributor

Looks good, suitable name too

@joelschmol
Copy link
Contributor Author

Shoutout zerobun

@quickdesh
Copy link
Contributor

One last thing before I merge, and I need you to do the same thing for both colors. Could you shift the string for the name of the colors to strings-aniyomi.xml instead?

@joelschmol
Copy link
Contributor Author

remove them from strings.xml and keep in strings-aniyomi.xml?

@quickdesh
Copy link
Contributor

Yes, shift the name of the string to the aniyomi file, for both colors

@joelschmol joelschmol closed this by deleting the head repository Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joelschmol @quickdesh