test_replication_origin fixed, optimized sql

ankane · Dec 7, 2023 · a6c33c8 · a6c33c8
1 parent 7f3d636
commit a6c33c8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/lib/pgsync/data_source.rb b/lib/pgsync/data_source.rb
@@ -106,15 +106,8 @@ def set_replication_origin(origin)
           CASE
             WHEN EXISTS (SELECT 1 FROM pg_replication_origin WHERE roname = $1) THEN null
             ELSE pg_replication_origin_create($1)
-          END;
-      SQL
-      execute(query, [origin])
-      query = <<~SQL
-        SELECT
-          CASE
-            WHEN pg_replication_origin_session_is_setup() THEN null
-            ELSE pg_replication_origin_session_setup($1)
-          END;
+          END,
+          pg_replication_origin_session_setup($1);
       SQL
       execute(query, [origin])
     end

diff --git a/test/sync_test.rb b/test/sync_test.rb
@@ -178,7 +178,6 @@ def test_disable_integrity_v2
 
   def test_replication_origin
     insert(conn1, "posts", [{"id" => 1}])
-    assert_error "Sync failed for 1 table: posts", "posts", config: true
     assert_works "posts --replication-origin=test --debug", config: true
     assert_equal [{"exists" => 1}], conn2.exec("SELECT 1 AS exists FROM pg_replication_origin WHERE roname = 'test'").to_a
   end