Replication origin support #204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ankane At this stage I would ask for your opinion for this PR and little help. We use pgsync extensively and have recognized that we have need for this kind of feature. Is this something that you would accept as part of the featureset of your project? If no, that is completely understandable and we will continue with our internal fork. If yes, then I would gladly receive guidance that is this implementation okay for you and I humbly ask for little help on how this should made to work with Ruby2.7 + Postgres 9.6 😅 |
|
Hi @pyrliu, thanks for the PR. Since this doesn't seem very common, I think it's better for a fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
purpose of this PR is to add support for
--replication-origin=foothat defines the replication origin setting to target database. This allows other sync/replication mechanisms to understand when data comes from pgsync and allows DBAs to configure setups for example to prevent triggering a cascade effect when pgsync is used with databases that have replication setup.