feat: Scoped Storage Migration Service, Notification & Deck Picker Implementation #13152

david-allison · 2023-01-25T02:40:02Z

Pull Request template

Purpose / Description

This Pull Request implements the foreground service which performs the Scoped Storage Migration, and hooks it up to the Deck Picker

Review Goals

Ensure alpha users will not be placed in a bad position by this. This PR moves us to 'developers can test the migration', I'd rather keep this as too unstable for alpha, despite the amount of testing, given the impact.
Question the onStartCommand isStarted logic
Determine the TODOs which need to be moved to the Plan

This also contains a couple refactorings which could be split out if requested in the review.

Fixes

Related #5304

Approach

Define a Service
Define code to run a repeated task
Define a Service Binder to abstract out the intricacies from DeckPicker
Define an API which determines the state of the migration

How Has This Been Tested?

⚠️ This needs more thorough testing. I'm submitting this PR to allow for this to occur. Once this testing is complete, we can allow 'GitHub alpha' users to use it.

Tested on my test collection. All media transferred.

Known Issues

Reviewer is not tied in to the migration process yet
Media is not blocked

Checklist

You have a descriptive commit message with a short title (first line, max 50 chars).
You have commented your code, particularly in hard-to-understand areas
You have performed a self-review of your own code
UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
UI Changes: You have tested your change using the Google Accessibility Scanner

TaskDelegate was used only as a generic 'start/progress/complete + result' interface, which isn't necessary and only increases coupling and complexity

github-actions · 2023-01-25T02:40:17Z

Message to maintainers, this PR contains strings changes.

Before merging this PR, it is best to run the "Sync Translations" GitHub action, then make and merge a PR from the i18n_sync branch to get translations cleaned out.
Then merge this PR, and immediately do another translation PR so the huge change made by this PR's key changes are all by themselves.

Read more about updating strings on the wiki,

BrayanDSO

About the overall process:

My AnkiDroid directory still exists after the migration with the "essential files". Shouldn't they be deleted as well?
I can't see the progress bar here, and the progress report string shows 0.00MB for the total. I think that the progress bar is enough, so we may not need the Migrated %s of %s MB string, as there won't be much time to translate it on most languages
- Tested on my phone, Samsung Galaxy Note 10 Lite, Android 13, One UI 5
- https://user-images.githubusercontent.com/69634269/214580402-3f2c1aed-f680-436f-aee6-d6abb752c27a.mp4

AnkiDroid/src/main/java/com/ichi2/anki/services/MigrationService.kt

AnkiDroid/src/main/java/com/ichi2/utils/Repeater.kt

AnkiDroid/src/main/java/com/ichi2/anki/services/MigrationService.kt

AnkiDroid/src/main/java/com/ichi2/anki/services/ServiceConnection.kt

BrayanDSO · 2023-01-25T12:31:56Z

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

    }

    /**
     * Show a dialog that explains no sync can occur during migration.
     */
    private fun warnNoSyncDuringMigration() {
-        // TODO: Fetch and display real numbers
+        // TODO: handle value updates


I suggest handling it by using a progress dialog (not for this PR, just an idea for the TODO task)

yes I was waiting for it, I have that part ready at my end

AnkiDroid/src/main/java/com/ichi2/anki/services/ServiceConnection.kt

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

AnkiDroid/src/main/java/com/ichi2/anki/services/MigrationService.kt

BrayanDSO · 2023-01-25T13:53:10Z

Oh, and why have you removed the Strings label?

criticalAY · 2023-01-25T14:08:57Z

@BrayanDSO I am the one working with the progress bar that is to be shown during migration and the UI element, Basically STOR-04 and STOR-05 so will pull the updates and then push the PR after this PR gets merged

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

BrayanDSO · 2023-01-25T19:47:54Z

Forgot to reply about your points:

Ensure alpha users will not be placed in a bad position by this. This PR moves us to 'developers can test the migration', I'd rather keep this as too unstable for alpha, despite the amount of testing, given the impact.

I think it is stable enough to alpha testers, and they can always refure to migrate or keep using an older version

Question the onStartCommand isStarted logic

Seems correct to me.

Determine the TODOs which need to be moved to the Plan

Dialog offering to migrate on startup
- After first install
- After postpone
Better migration complete message
- My preference is snackbar if on-app + notification out of the app, but toast instead of snackbar is acceptable inside the app

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

david-allison · 2023-01-31T00:13:48Z

Fixed the issue with remaining being 0: getFileSize was the culprit (conflict didn't exist, AND it threw if we tried to get the directory size of an empty directory)

david-allison · 2023-01-31T11:49:55Z

My AnkiDroid directory still exists after the migration with the "essential files". Shouldn't they be deleted as well?

We want to keep the collection as a backup
We want to add a text file explaining the migration for advanced users

BrayanDSO

LGTM.

Left an implementer's choice comment

AnkiDroid/src/main/res/values/01-core.xml

A service which migrates the AnkiDroid collection from a legacy directory to an app-specific directory. Contains a persistent notification and is designed to be run as a foreground service Issue 5304

* Tapping the Migration icon on the Deck Picker offers to migrate storage * Implements binding to MigrationService to allow: * Refresh when migration is completed * Update of progress, for an in-app dialog

This hasn't worked for directories on any of my devices: ``` Recovering failed rename /storage/emulated/0/AnkiDroid/collection.media to /storage/emulated/0/Android/data/com.ichi2.anki/files/AnkiDroid20/collection.media Rename recovery failed android.system.ErrnoException: rename failed: EXDEV (Cross-device link) at libcore.io.Linux.rename(Native Method) ... ``` We previously assumed this would fail for a directory first. So did not set `attemptRename` to false for a file copy. Now we no longer handle directories, so set this value on a file copy.

Added in 0b869c7 - doesn't seem intentional

mikehardy · 2023-02-05T22:29:07Z

Can someone please explain the expected testing flow? I did this:

prep1) git co v2.15.6
prep2) (make sure I am on JDK that is compatible with the old version, for me that is running jdk11, normally I'm testing higher versions...)
prep3) ./gradlew clean installPlayDebug --rerun-tasks (the clean and --rerun-tasks are superstitious when I'm testing, if caching is working correctly in gradle they are unnecessary extra compile/build work)
prep4) sync my ankiweb test account so I have a functioning pre-historic AnkiDroid running with data in /sdcard/AnkiDroid

Now I try to test:

test0) make sure you have the github command line utility installed, because it's useful, it is called gh
test1) gh pr checkout 13152
test2) ./gradlew clean installPlayDebug --rerun-tasks (again, I'm superstitious about clean builds)
test3) I have two AnkiDroid apps installed because one has package name suffix .debug now, okay, click that one
test4) ...nothing? I allowed it access to storage and I have an empty deck list. It doesn't see my old collection

If I sync etc, the collection is already scoped storage so I'm not offered any migration.

🤔

david-allison · 2023-02-06T04:40:33Z

TL;DR:

we can manually set the collection location to a legacy location (/storage/emulated/0/AnkiDroid). A collection will be created, and the migration can be tested.

com.ichi2.anki.debug has been introduced to ensure that development-based activities will not uninstall com.ichi2.anki (equivalent to a data wipe).

ci: debug identifier -> 'com.ichi2.anki.debug' #13089

A new collection is now initialised at /storage/emulated/0/Android/data/com.ichi2.anki.debug/files. This does not require a storage update.

Add a BuildConfig option to use legacy storage #13136
- pending: [Bug] deckPath location should be in a subfolder of files #13169

An existing user would have a collection at /storage/emulated/0/AnkiDroid. This requires a storage upgrade, and the UI to do so appears

note Since changes to main affect alpha testers, and we want this functionality to be opt-in while additional testing rakes place, this UI is currently optional (a button to migrate is provided).

We have not yet moved to API 30, so we can manually set the collection location to a legacy location (/storage/emulated/0/AnkiDroid). A collection will be created, and the migration can be tested.

mikehardy · 2023-02-06T13:53:59Z

Hmm - what I thought was strange was that I had a collection there in /sdcard/AnkiDroid - why didn't the app (.debug suffix or not...) see it and use it? Even if the migration was optional this seems like the prime testing flow doesn't it? (start with 2.15.6 synced with ankiweb, install this, check it? It was the most "happy path" thing I could think of...)

I'll try with a manual storage location setting as new step test4 and current step test4 will become test5

Thanks!

mikehardy · 2023-02-06T14:02:00Z

Okay that worked, but here's another testing note, that is not fixable really: Don't do this on a Play Services emulator or you can't use su to go into inaccessible areas of the filesystem (that is, the migrated scoped storage location...) which is obvious unless you forget 😆

Anyway, it seemed to work fine. A couple UX notes:

1- The migrate button on deck picker stayed there post-migration until deck picker was made to UI refresh (app background + foreground did it for me)
2- When the migration is really really fast (I did it on a small collection first) I get the toast that says I can keep using AnkiDroid but there is no notification about the migration (too fast!) and no indication that it finished (see item 1) so I was a little confused if it was still running or not

But it worked it seems! More testing in a bit on a non-play services emulator and with a large collection, and I'll read through the code etc as well.

BrayanDSO · 2023-02-06T14:04:23Z

why didn't the app (.debug suffix or not...) see it and use it?

New installs default to the in-app directory (e.g. storage/0/emulated/com.ichi2.anki.debug/files). If you want to make new installs default to the legacy storage, add legacy_storage=true to your local.properties file

BrayanDSO · 2023-02-06T14:10:28Z

When the migration is really really fast (I did it on a small collection first) I get the toast that says I can keep using AnkiDroid

The snackbar shouldn't be shown if the essential files migration is too fast (800ms). Apparently this PR breaks that. Good catch

and no indication that it finished (see item 1) so I was a little confused if it was still running or not

#13131

criticalAY · 2023-02-06T14:17:30Z

When the migration is really really fast (I did it on a small collection first) I get the toast that says I can keep using AnkiDroid

The snackbar shouldn't be shown if the essential files migration is too fast (800ms). Apparently this PR breaks that. Good catch

and no indication that it finished (see item 1) so I was a little confused if it was still running or not

#13131

Yes waiting for this to be merged then will implement and push

mikehardy · 2023-02-06T15:58:27Z

Great - thanks and sorry if I'm duplicating already known stuff. I'm attempting to help with review + testing on this one but I'm catching up on progress and have obviously missed huge amounts of work + tracking, so I'm sadly duplicating some comments. Hopefully it's still a net positive :-)

mikehardy

This all looks good on a first and second scan, and it didn't crash or anything when I ran it locally - I'd just be slowing it down further by making it wait more. Let's go! Also, of course: this is awesome as a chunk of progress, really excited

mikehardy · 2023-02-07T14:53:28Z

@criticalAY it seemed like you had some work queued up behind this? I'm going to do a string sync now but hopefully you're unblocked 🚂

criticalAY · 2023-02-07T15:23:06Z

@criticalAY it seemed like you had some work queued up behind this? I'm going to do a string sync now but hopefully you're unblocked 🚂

Yep! Thankyou I'll go ahead as soon as it gets merged
Edit : it's already merged so I'll pull the updates:)

oakkitten · 2023-02-07T20:31:51Z

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

+     * See: #5304
+     * @return true: Interrupt startup. `false`: continue as normal
+     */
+    open fun startingStorageMigrationInterruptsStartup(): Boolean {


The name of this function is super hard to read and does not sufficiently reflect what it does. The documentation is not very helpful. I suggest to put into the documentation a high-level overview of the issue it solves.

You could perhaps slightly improve it by thinking of more simple names, e.g.

enum class ShouldContinueActivityStartup { Yes, No } fun migrateStorageIfNeeded(): ActivityStartup { ... } fun handleStartup() { // bad name, but w/e if (migrateStorageIfNeeded() == ShouldContinueActivityStartup.No) return ... }

But really, the main problem is that this function, being itself very high-level, does very much high-level actions. Consider removing it altogether:

fun handleStartup() { val migrationStatus = ScopedStorageService.migrationStatus(this) when (migrationStatus) { Status.NEEDS_MIGRATION -> TODO("Propose migration") Status.IN_PROGRESS -> startMigrateUserDataService() Status.REQUIRES_PERMISSION -> requestStoragePermission() } val shouldHaltStartup = migrationStatus == Status.REQUIRES_PERMISSION if (shouldHaltStartup) return ... }

oakkitten · 2023-02-07T20:48:16Z

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

@@ -771,7 +831,7 @@ open class DeckPicker :
            }
            R.id.action_scoped_storage_migrate -> {
                Timber.i("DeckPicker:: migrate button pressed")
-                showDialogThatOffersToMigrateStorage()
+                showDialogThatOffersToMigrateStorage(onPostpone = null)


This is not very important, but I'm not sure if onPostpone should have been a part of this PR

oakkitten · 2023-02-07T21:14:29Z

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

@@ -936,6 +996,18 @@ open class DeckPicker :
        mFloatingActionMenu.isFABOpen = savedInstanceState.getBoolean("mIsFABOpen")
    }

+    fun onStorageMigrationCompleted() {
+        migrationService.unbind(this)


The service should stop itself after finishing the migration. I am assuming that we don't have to unbind from it here, or at all; if we do, it should probably happen not in this method. If this needs to be here, I'd like a comment regarding the necessity of this line.

oakkitten · 2023-02-07T21:15:09Z

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

@@ -936,6 +996,18 @@ open class DeckPicker :
        mFloatingActionMenu.isFABOpen = savedInstanceState.getBoolean("mIsFABOpen")
    }

+    fun onStorageMigrationCompleted() {
+        migrationService.unbind(this)
+        invalidateOptionsMenu() // reapply the sync icon


“reapply the sync icon” is hard to understand

oakkitten · 2023-02-07T21:15:32Z

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

+
+    override fun onStart() {
+        super.onStart()
+        if (userMigrationIsInProgress(this)) {


I feel that we should use either this, or ScopedStorageService.migrationStatus(), throughout.

oakkitten · 2023-02-08T00:05:01Z

AnkiDroid/src/main/java/com/ichi2/anki/services/ServiceConnection.kt

+ *
+ * @param T The service to encapsulate. Note: service's [Service.onBind] must return a [SimpleBinder]
+ */
+abstract class ServiceConnection<T : Service> {


Nit: I'm not entirely sure about this.

When I had to use a 1 activity + 1 service combination, I finally settled on a simplified approach of putting the service into a static variable (Java times). No binders, no boilerplate. Coupled with an event bus (actually EventBus) approach (now obsolete but yeah), it was, I think, an approach that should be still valid today with some reasonable modifications.

To be fair, on of my gripes was the async nature of onServiceConnected IIRC. I wanted that to be sync. So I chose other options that allowed me to do more seamless animations and stuff. This might be irrelevant for AnkiDroid and my memories might be obsolete, so this is no more than food for thought

The bottom line here is, I think this entire class might be an overcomplication. I see that it's generic and is supposed to simplify things, but can't we get away with just not using a connection, or using one that merely forwards to the service object itself?

AnkiDroid/src/main/java/com/ichi2/anki/services/ServiceConnection.kt

oakkitten · 2023-02-08T00:23:51Z

AnkiDroid/src/main/java/com/ichi2/utils/FileUtil.kt

+            return file.length()
+        } else if (!file.exists()) {
+            return 0L
+        }


This seems to be doing the same thing that CoroutineScope.calculateSize(file: File) does. Can we use that?

oakkitten · 2023-02-08T00:26:19Z

AnkiDroid/src/main/java/com/ichi2/utils/HandlerUtils.kt

@@ -84,3 +84,11 @@ object HandlerUtils {
        )
    }
 }
+
+fun runOnUiThread(runnable: () -> Unit) {


I suggest consolidating this with stuff like executeFunctionUsingHandler, executeFunctionWithDelay, etc

oakkitten · 2023-02-08T00:28:01Z

AnkiDroid/src/main/java/com/ichi2/utils/Repeater.kt

+ * @param delayMs the interval to wait after the execution of [runnable] before the next call is made
+ * @param runnable Called once every [delayMs] until [terminate] is called
+ */
+class Repeater private constructor(val delayMs: Long, val runnable: () -> Unit) {


I'd suggest replacing this class with a coroutine, or removing the logic entirely in favor of StateFlow and friends

github-actions · 2023-03-13T21:34:42Z

Hi there @david-allison! This is the OpenCollective Notice for PRs merged from 2023-02-01 through 2023-02-28

If you are interested in compensation for this work, the process with details is here:

https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please note that GSoC contributions are okay for this process. Our philosophy is that our users have donated to AnkiDroid for all contributions. The only PRs that will not go through the OpenCollective process are ones directly related to am accepted GSoC project from a selected participant, since those receive a stipend from GSoC itself.

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!

Make MigrateUserData not be a TaskDelegate

9081007

TaskDelegate was used only as a generic 'start/progress/complete + result' interface, which isn't necessary and only increases coupling and complexity

david-allison changed the title ~~feat: Scoped Storage Migration Service, Notification & Implementation~~ feat: Scoped Storage Migration Service, Notification & Deck Picker Implementation Jan 25, 2023

github-actions bot added the Strings label Jan 25, 2023

david-allison added Review High Priority Request for high priority review Scoped storage and removed Strings labels Jan 25, 2023

BrayanDSO requested changes Jan 25, 2023

View reviewed changes

BrayanDSO added the Needs Author Reply Waiting for a reply from the original author label Jan 25, 2023

BrayanDSO reviewed Jan 25, 2023

View reviewed changes

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt Outdated Show resolved Hide resolved

BrayanDSO reviewed Jan 25, 2023

View reviewed changes

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt Show resolved Hide resolved

BrayanDSO reviewed Jan 25, 2023

View reviewed changes

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt Show resolved Hide resolved

david-allison added the Strings label Jan 28, 2023

david-allison force-pushed the scoped-storage-2023-2 branch from 0ea5a24 to 3711434 Compare January 28, 2023 15:20

david-allison removed the Needs Author Reply Waiting for a reply from the original author label Jan 28, 2023

david-allison force-pushed the scoped-storage-2023-2 branch from 3711434 to 15b7bae Compare January 31, 2023 00:11

david-allison requested a review from BrayanDSO January 31, 2023 11:48

BrayanDSO approved these changes Jan 31, 2023

View reviewed changes

AnkiDroid/src/main/res/values/01-core.xml Outdated Show resolved Hide resolved

BrayanDSO added the Needs Second Approval Has one approval, one more approval to merge label Jan 31, 2023

criticalAY approved these changes Feb 1, 2023

View reviewed changes

david-allison added 4 commits February 4, 2023 03:35

feat: Storage Migration service

1a8fa27

A service which migrates the AnkiDroid collection from a legacy directory to an app-specific directory. Contains a persistent notification and is designed to be run as a foreground service Issue 5304

feat: Deck Picker - Storage Migration Service

e679bde

* Tapping the Migration icon on the Deck Picker offers to migrate storage * Implements binding to MigrationService to allow: * Refresh when migration is completed * Update of progress, for an in-app dialog

Remove noisy log when importing

1c59e65

Added in 0b869c7 - doesn't seem intentional

david-allison force-pushed the scoped-storage-2023-2 branch from 15b7bae to 1c59e65 Compare February 4, 2023 03:36

mikehardy mentioned this pull request Feb 7, 2023

[Bug] Migrate stuck on "Migrating 5 media files" #13212

Closed

4 tasks

mikehardy approved these changes Feb 7, 2023

View reviewed changes

mikehardy merged commit 179ce6f into ankidroid:main Feb 7, 2023

github-actions bot added this to the 2.16 release milestone Feb 7, 2023

github-actions bot removed Review High Priority Request for high priority review Needs Second Approval Has one approval, one more approval to merge labels Feb 7, 2023

david-allison deleted the scoped-storage-2023-2 branch February 7, 2023 22:04

oakkitten reviewed Feb 8, 2023

View reviewed changes

oakkitten mentioned this pull request Feb 19, 2023

added migration progess bar #13219

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Scoped Storage Migration Service, Notification & Deck Picker Implementation #13152

feat: Scoped Storage Migration Service, Notification & Deck Picker Implementation #13152

david-allison commented Jan 25, 2023

github-actions bot commented Jan 25, 2023

BrayanDSO left a comment •

edited

Loading

BrayanDSO Jan 25, 2023

criticalAY Jan 25, 2023

BrayanDSO commented Jan 25, 2023

criticalAY commented Jan 25, 2023

BrayanDSO commented Jan 25, 2023

david-allison commented Jan 31, 2023

david-allison commented Jan 31, 2023

BrayanDSO left a comment

mikehardy commented Feb 5, 2023

david-allison commented Feb 6, 2023 •

edited

Loading

mikehardy commented Feb 6, 2023

mikehardy commented Feb 6, 2023

BrayanDSO commented Feb 6, 2023

BrayanDSO commented Feb 6, 2023 •

edited

Loading

criticalAY commented Feb 6, 2023

mikehardy commented Feb 6, 2023

mikehardy left a comment

mikehardy commented Feb 7, 2023

criticalAY commented Feb 7, 2023 •

edited

Loading

oakkitten Feb 7, 2023 •

edited

Loading

oakkitten Feb 7, 2023 •

edited

Loading

oakkitten Feb 7, 2023

oakkitten Feb 7, 2023

oakkitten Feb 7, 2023 •

edited

Loading

oakkitten Feb 8, 2023

oakkitten Feb 8, 2023 •

edited

Loading

oakkitten Feb 8, 2023

oakkitten Feb 8, 2023

github-actions bot commented Mar 13, 2023

feat: Scoped Storage Migration Service, Notification & Deck Picker Implementation #13152

feat: Scoped Storage Migration Service, Notification & Deck Picker Implementation #13152

Conversation

david-allison commented Jan 25, 2023

Pull Request template

Purpose / Description

Review Goals

Fixes

Approach

How Has This Been Tested?

Known Issues

Checklist

github-actions bot commented Jan 25, 2023

BrayanDSO left a comment • edited Loading

Choose a reason for hiding this comment

BrayanDSO Jan 25, 2023

Choose a reason for hiding this comment

criticalAY Jan 25, 2023

Choose a reason for hiding this comment

BrayanDSO commented Jan 25, 2023

criticalAY commented Jan 25, 2023

BrayanDSO commented Jan 25, 2023

david-allison commented Jan 31, 2023

david-allison commented Jan 31, 2023

BrayanDSO left a comment

Choose a reason for hiding this comment

mikehardy commented Feb 5, 2023

david-allison commented Feb 6, 2023 • edited Loading

mikehardy commented Feb 6, 2023

mikehardy commented Feb 6, 2023

BrayanDSO commented Feb 6, 2023

BrayanDSO commented Feb 6, 2023 • edited Loading

criticalAY commented Feb 6, 2023

mikehardy commented Feb 6, 2023

mikehardy left a comment

Choose a reason for hiding this comment

mikehardy commented Feb 7, 2023

criticalAY commented Feb 7, 2023 • edited Loading

oakkitten Feb 7, 2023 • edited Loading

Choose a reason for hiding this comment

oakkitten Feb 7, 2023 • edited Loading

Choose a reason for hiding this comment

oakkitten Feb 7, 2023

Choose a reason for hiding this comment

oakkitten Feb 7, 2023

Choose a reason for hiding this comment

oakkitten Feb 7, 2023 • edited Loading

Choose a reason for hiding this comment

oakkitten Feb 8, 2023

Choose a reason for hiding this comment

oakkitten Feb 8, 2023 • edited Loading

Choose a reason for hiding this comment

oakkitten Feb 8, 2023

Choose a reason for hiding this comment

oakkitten Feb 8, 2023

Choose a reason for hiding this comment

github-actions bot commented Mar 13, 2023

BrayanDSO left a comment •

edited

Loading

david-allison commented Feb 6, 2023 •

edited

Loading

BrayanDSO commented Feb 6, 2023 •

edited

Loading

criticalAY commented Feb 7, 2023 •

edited

Loading

oakkitten Feb 7, 2023 •

edited

Loading

oakkitten Feb 7, 2023 •

edited

Loading

oakkitten Feb 7, 2023 •

edited

Loading

oakkitten Feb 8, 2023 •

edited

Loading