-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable some advanced settings if migrating storage #13329
Disable some advanced settings if migrating storage #13329
Conversation
Message to maintainers, this PR contains strings changes.
Read more about updating strings on the wiki, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - strings are clear right now, easy merge
9d23340
to
ece0e14
Compare
replaced implementation with a summary change. Thanks to @BrayanDSO for the idea |
AnkiDroid/src/main/java/com/ichi2/anki/preferences/AdvancedSettingsFragment.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/preferences/AdvancedSettingsFragment.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/preferences/AdvancedSettingsFragment.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/preferences/AdvancedSettingsFragment.kt
Outdated
Show resolved
Hide resolved
ece0e14
to
1b8ddad
Compare
Migrating storage is a high-risk operation as it involves copying the user's media Disable: * AnkiDroid Directory * Corruption: Media from the one collection is moved to the other * V3 Migration * High Risk: Disabling defensively Grey the preference and set the summary Issue 5304 Issue 13094
1b8ddad
to
b111546
Compare
Is this one good to go (with the string PR)? |
There's a fair chunk of strings activity (https://crowdin.com/project/ankidroid/activity-stream) since last build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean!
I just checked crowdin activity and there has been more from 2 people in between me cleaning strings and right now, but their translations all check out, so the strings PR will be easy
Pull Request template
Purpose / Description
Migrating storage is a high-risk operation as it involves copying the user's media
Disable:
Related
Approach
Grey the preference and set a summary
How Has This Been Tested?
Manually: API 33 emulator
Learning
Unused n this PR
click
handler won't stop the change/dialog eventclick
handler doesn't fireBut we can handle the dialog event separately to catch this
On switch/checkbox preferences, all we need to do is override
setOnPreferenceChangeListener
AFTER it's been set conditionallyChecklist