#5740 - Add Welcome Dialog Explaining Permissions

[david-allison]

Purpose / Description

Some users din't feel comfortable about us requiring access to external storage.

Fixes

Fixes #5740

Approach

We add a dialog explaining that we don't perform any malicious activities with this in order to hopefully alleviate concerns.

How Has This Been Tested?

Checklist

• You have not changed whitespace unnecessarily (it makes diffs hard to read)
• You have a descriptive commit message with a short title (first line, max 50 chars).
• Your code follows the style of the project (e.g. never omit braces in if statements)
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code

[david-allison]

Wording changes would be useful. Probably "storage access" -> "storage permissions"

[mikehardy]

Minor wording change, suggested re-ordering of ok click handler

[mikehardy]

I blew up master CI by merging #5597 which had passed long ago before we included a lint check, and it fails the lint check post merge 🤦‍♂ - just pushed a fix for that and master should go clean but you'll probably have to rebase from master HEAD and force-push to kick CI again

Then unrelated Travis did some sort of maintenance and macOS builds are super intermittent right now, but those I can keep kicking until they go green...

[mikehardy]

One separate question before I approve, what happens on a tiny screen? The API16 emulator I keep around has two purposes - one it verifies the oldest API we still can sync ankiweb too, the other is that I have it configured as an old + tiny screen phone (Nexus S IIRC). Just wondering if there is enough real estate for the whole message

[david-allison]

One separate question before I approve, what happens on a tiny screen? The API16 emulator I keep around has two purposes - one it verifies the oldest API we still can sync ankiweb too, the other is that I have it configured as an old + tiny screen phone (Nexus S IIRC). Just wondering if there is enough real estate for the whole message

Sorry, forgot that in the testing notes. It works fine with a scrollbar.

[david-allison]

Rebased, squashed and pushed.

Let's hope the CI still passes 🤞

[timrae]

Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
           

See the complete overview on Codacy

[mikehardy]

Sweet - this will go in alpha53 later today

[mikehardy]

2.10alpha54 released just now has this whenever google delivers it to you