Get next time for review in WebView

[krmanik]

Pull Request template

Purpose / Description

When redesigning card in CSS & JS, then it may required to show next review time below buttons. This is continuation of #6307

Fixes

Fixes Link to the issues.

Approach

Added javascript interface in WebView settings then added functions in under
@JavascriptInterface

How Has This Been Tested?

Tested on emulator,
Add following function in <script> tag in card templates, then use at/below buttons designed in css & js

<script>
    console.log(AnkiDroidJS.ankiShowNextTime1());
    console.log(AnkiDroidJS.ankiShowNextTime2());
    console.log(AnkiDroidJS.ankiShowNextTime3());
    console.log(AnkiDroidJS.ankiShowNextTime4());
</script>

Learning (optional, can help others)

https://developer.android.com/reference/android/webkit/WebView#addJavascriptInterface(java.lang.Object,%20java.lang.String)

Checklist

Please, go through these checks before submitting the PR.

• [ x ] You have not changed whitespace unnecessarily (it makes diffs hard to read)
• [ x ] You have a descriptive commit message with a short title (first line, max 50 chars).
• [ x ] Your code follows the style of the project (e.g. never omit braces in if statements)
• [ x ] You have commented your code, particularly in hard-to-understand areas
• [ x ] You have performed a self-review of your own code

[krmanik]

This will be useful when card developer designing cards and want to show next time below custom answer buttons.

[krmanik]

Is there any improvement for this PR?

[mikehardy]

Hi @infinyte7 there is a conflict right now that needs resolution but I think the main thing is just that we're a bit constrained by available time so we haven't had a good look yet, sorry

[krmanik]

It's okay. When you have time then review this PR.
Thank you.

[david-allison]

Could do with a line of JavaDoc documentation about whether "2" means the second button, or always means the hard button.

What is returned when the first card is a learn card in SchedV1, and "hard" is requested?

No issues with the functionality, looks good to me!

[krmanik]

It will be good with a page containing details and usage of all functionality related to webview / java or javascript interface in wiki page.
Like this I have done
https://github.com/ankidroid/Anki-Android/wiki/Advanced-formatting#designing-custom-cards-layout-for-buttons

May be more good way, like this
https://www.cyberciti.biz/faq/linux-unix-creating-a-manpage/
http://www.linuxhowtos.org/System/creatingman.htm

[mikehardy]

Nice! I like that (the documentation adds) - would be good perhaps to cross-link to the HTML/JS debugging page, and also directly link to card.js internally as the "source of truth", plus start adding information about API registration and the reason behind it. Might be good to make a whole separate page for "AnkiDroid Javascript API" developers and link to it from where you've started adding things

And it looks like there's a conflict now in one of the files, possibly because of a related change from you that I just merged

[david-allison]

LGTM!

[krmanik]

Yes, I will add the all information as suggested in a separate page.

[mikehardy]

Just waiting for conflict resolution then re-request review from me @infinyte7 and I'll mark it pending merge to make sure CI goes green

[krmanik]

How can I add re-request review from you @mikehardy ?

[mikehardy]

Up at the very top right you'll see our review states, and you can hit the little re-do icon for it to trigger a request to me (which gives me a notification, so I know to do it!)

[mikehardy]

Except I won't even be in the review state area unless I review it :-)
Needs a conflict resolve

[david-allison]

No need to ask me to review again unless you've changed something significant. Looks as good as it did the first time!

[krmanik]

Is conflict resolved or should I create a separate PR? @mikehardy

[david-allison]

@infinyte7 If you scroll down, you should be able to see:

The warning at the bottom means there's still a conflict to be resolved

[krmanik]

It seems resolved.

[mikehardy]

LGTM