Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change jsdoc into a peerDependency #45

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

GMartigny
Copy link
Contributor

Pull Request Template

Description

Change jsdoc dependency into a peerDependency. This allow your users to use any version of jsdoc@3. Since this package don't directly depend on jsdoc, this should be the way to go.
This also prevent NPM from installing jsdoc twice on your users.

Type of change

Please mark options that is/are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Other (if so, then explain below briefly)

This only change the way people consume your package.

@ankitskvmdam ankitskvmdam merged commit d64a608 into ankitskvmdam:master Nov 4, 2020
@ankitskvmdam
Copy link
Owner

Thanks!

@GMartigny GMartigny deleted the peerDependencies branch September 17, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants