Skip to content
This repository has been archived by the owner on Jun 4, 2022. It is now read-only.

TypeError: Cannot read property 'replace' of null #362

Closed
eccstartup opened this issue Feb 25, 2018 · 2 comments
Closed

TypeError: Cannot read property 'replace' of null #362

eccstartup opened this issue Feb 25, 2018 · 2 comments

Comments

@eccstartup
Copy link

Any time you type in repl TAB after a space character will cause lumo to quit.

$ lumo
Lumo 1.8.0
ClojureScript 1.9.946
Node.js v9.2.0
 Docs: (doc function-name-here)
       (find-doc "part-of-name-here")
 Source: (source function-name-here)
 Exit: Control+D or :cljs/quit or exit

cljs.user=> (+ readline.js:1032
            throw err;
            ^

TypeError: Cannot read property 'replace' of null
    at Object.clojure.string.replace_all (<embedded>:2055:385)
    at Object.clojure.string.replace (<embedded>:2058:191)
    at Object.lumo.repl.is_completion_QMARK_ (<embedded>:6655:332)
    at <embedded>:6680:148
    at cljs.core.LazySeq.fn (<embedded>:1122:275)
    at cljs.core.LazySeq.sval (<embedded>:794:151)
    at cljs.core.LazySeq.cljs$core$ISeqable$_seq$arity$1 (<embedded>:800:255)
    at Object.cljs.core.seq (<embedded>:506:172)
    at Function.cljs.core.seq_reduce.cljs$core$IFn$_invoke$arity$3 (<embedded>:660:84)
    at cljs.core.LazySeq.cljs$core$IReduce$_reduce$arity$3 (<embedded>:799:250)
@arichiardi
Copy link
Collaborator

Thanks for reporting! I will have a look.

@arichiardi
Copy link
Collaborator

I think we need to add some more of those symbols in this regex here https://github.com/anmonteiro/lumo/blob/master/src/cljs/snapshot/lumo/repl.cljs, should be a pretty straightforward patch if you would like to contribute it.

arichiardi added a commit that referenced this issue Mar 4, 2018
Plus test that we do the right thing.
arichiardi added a commit that referenced this issue Mar 5, 2018
Plus test that we do the right thing.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants