This repository has been archived by the owner on Jun 4, 2022. It is now read-only.
Port planck's eval implementation #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
reviewed
Jun 5, 2017
src/cljs/snapshot/lumo/repl.cljs
Outdated
| ;; emit function values into JavaScript as numeric | ||
| ;; references that are looked up. | ||
|
|
||
| (defonce ^:private fn-index (atom 0)) |
There was a problem hiding this comment.
these don't need to be atoms. can you switch them to volatiles?
There was a problem hiding this comment.
Great ideas are always worth stealing. planck-repl/planck@0f29414
anmonteiro
reviewed
Jun 5, 2017
src/cljs/snapshot/lumo/repl.cljs
Outdated
| (defn- clear-fns! | ||
| "Clears saved functions." | ||
| [] | ||
| (reset! fn-refs {})) |
anmonteiro
reviewed
Jun 5, 2017
src/cljs/snapshot/lumo/repl.cljs
Outdated
| (defn- put-fn | ||
| "Saves a function, returning a numeric representation." | ||
| [f] | ||
| (let [n (swap! fn-index inc)] |
|
This looks great! Left a few inline comments and I'll merge once you address them. Thanks! |
|
Sorry about the messy history! The windows specific commit should go in another branch. |
|
thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #146
Question: should the new
lumo.repl/evalbe exposed anywhere else?