This repository has been archived by the owner on Jun 4, 2022. It is now read-only.
Execute *main-cli-fn* if set and no -m #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichiardi
changed the title
anmonteiro
reviewed
Aug 22, 2017
src/cljs/snapshot/lumo/core.cljs
Outdated
| @@ -16,3 +16,8 @@ | |||
| ([] (exit nil)) | |||
| ([code] | |||
| (js/process.exit code))) | |||
|
|
|||
| (defn run-main-cli-fn | |||
anmonteiro
reviewed
Aug 22, 2017
src/js/cljs.js
Outdated
| @@ -437,6 +437,14 @@ async function startClojureScriptEngine(opts: CLIOptsType): Promise<mixed> { | |||
| if (mainNsName) { | |||
| initClojureScriptEngine(opts); | |||
| runMain(mainNsName, args); | |||
| } else { | |||
| execute( | |||
| "(do (require 'lumo.core) (lumo.core/run-main-cli-fn))", | |||
There was a problem hiding this comment.
shouldn't need to require lumo.core if we move *main-cli-fn* to lumo.repl
arichiardi
force-pushed
the
handle-main-cli-fn
branch
from
1b2eb78
to
7e61245
Compare
arichiardi
changed the title
arichiardi
force-pushed
the
handle-main-cli-fn
branch
from
7e61245
to
9e83cde
Compare
anmonteiro
reviewed
Aug 22, 2017
src/js/cljs.js
Outdated
| if (!mainNsName && !repl) { | ||
| initClojureScriptEngine(opts); | ||
| execute( | ||
| "(require 'lumo.repl) (lumo.repl/run-main-cli-fn)", |
There was a problem hiding this comment.
I wonder if we really need to require lumo.repl
There was a problem hiding this comment.
we should probably just create a JS function that calls lumo.repl/run-main-cli-fn like we do above for runMain
There was a problem hiding this comment.
It does need to require, I tried without and It was failing. About the JS function it could be done also in another PR as refinement, but if just a wrapper, I am not sure about the value..
arichiardi
force-pushed
the
handle-main-cli-fn
branch
from
9e83cde
to
152f71c
Compare
anmonteiro
added a commit
that referenced
this pull request
Sep 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It attempts to fix #235.
but does not really compile and exits with an errorProblem solved, works very well