Skip to content

Commit

Permalink
Merge branch 'master' into AGDNS-1982-fix-rdns-http
Browse files Browse the repository at this point in the history
  • Loading branch information
EugeneOne1 committed Apr 15, 2024
2 parents 0be18b9 + df7f19e commit a7d5023
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,15 @@ NOTE: Add new changes BELOW THIS COMMENT.

- The ability to apply an invalid configuration for private RDNS, which led to
server inoperability.
- Ignoring query log for clients with ClientID set ([#5812]).
- Subdomains of `in-addr.arpa` and `ip6.arpa` containing zero-length prefix
incorrectly considered invalid when specified for private RDNS upstream
servers ([#6854]).
- Unspecified IP addresses aren't checked when using "Fastest IP address" mode
([#6875]).

[#5345]: https://github.com/AdguardTeam/AdGuardHome/issues/5345
[#5812]: https://github.com/AdguardTeam/AdGuardHome/issues/5812
[#6854]: https://github.com/AdguardTeam/AdGuardHome/issues/6854
[#6875]: https://github.com/AdguardTeam/AdGuardHome/issues/6875

Expand Down
8 changes: 7 additions & 1 deletion internal/dnsforward/stats.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,13 @@ func (s *Server) processQueryLogsAndStats(dctx *dnsContext) (rc resultCode) {

log.Debug("dnsforward: client ip for stats and querylog: %s", ipStr)

ids := []string{ipStr, dctx.clientID}
ids := []string{ipStr}
if dctx.clientID != "" {
// Use the ClientID first because it has a higher priority. Filters
// have the same priority, see applyAdditionalFiltering.
ids = []string{dctx.clientID, ipStr}
}

qt, cl := q.Qtype, q.Qclass

// Synchronize access to s.queryLog and s.stats so they won't be suddenly
Expand Down

0 comments on commit a7d5023

Please sign in to comment.