Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]fix(response): return empty dict if immat is null #420

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Conversation

HAEKADI
Copy link
Contributor

@HAEKADI HAEKADI commented Sep 17, 2024

When immatriculation is null, typically for non-diffusible items, the API returns an error because None is not considered a valid value in the Pydantic model for this object. This PR introduces support for the None option. Additionally, "La Poste" is missing from the RNE stock, resulting in an empty immatriculation object and a null value for date_mise_a_jour_rne. This causes the end-to-end tests to fail, as "La Poste" is used in many test cases.

@HAEKADI HAEKADI requested a review from XavierJp as a code owner September 17, 2024 15:54
@HAEKADI HAEKADI self-assigned this Sep 17, 2024
@HAEKADI HAEKADI added bug Something isn't working API payload labels Sep 17, 2024
@HAEKADI HAEKADI added the CI label Sep 18, 2024
@HAEKADI HAEKADI merged commit ddc3152 into main Sep 18, 2024
10 checks passed
@HAEKADI HAEKADI deleted the fix-immat branch September 18, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API payload bug Something isn't working CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants