Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor IO #66

Merged
merged 1 commit into from
May 23, 2023
Merged

Refactor IO #66

merged 1 commit into from
May 23, 2023

Conversation

jonaprieto
Copy link
Collaborator

No description provided.

@jonaprieto jonaprieto requested a review from lukaszcz May 23, 2023 16:13
@jonaprieto jonaprieto marked this pull request as draft May 23, 2023 16:13
@jonaprieto jonaprieto marked this pull request as ready for review May 23, 2023 16:26
@jonaprieto jonaprieto merged commit d40b0b9 into main May 23, 2023
@jonaprieto jonaprieto deleted the refactor branch May 23, 2023 16:46
lukaszcz
lukaszcz reviewed May 31, 2023
View reviewed changes
Copy link
Contributor

@lukaszcz lukaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR broke the IO in the standard library! How did it pass the tests?

@lukaszcz lukaszcz mentioned this pull request May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszcz lukaszcz lukaszcz approved these changes

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonaprieto @lukaszcz