Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional braces in case syntax #2778

Merged
merged 11 commits into from
May 22, 2024
Merged

Optional braces in case syntax #2778

merged 11 commits into from
May 22, 2024

Conversation

lukaszcz
Copy link
Collaborator

@lukaszcz lukaszcz commented May 13, 2024 •
edited
Loading

@lukaszcz lukaszcz added this to the 0.6.2 milestone May 13, 2024
@lukaszcz lukaszcz self-assigned this May 13, 2024
@lukaszcz lukaszcz requested review from janmasrovira and paulcadman and removed request for janmasrovira May 14, 2024 13:04
@lukaszcz lukaszcz marked this pull request as ready for review May 14, 2024 13:10
janmasrovira
janmasrovira reviewed May 15, 2024
View reviewed changes
Copy link
Collaborator

@janmasrovira janmasrovira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be happy if we could replace the Bool argument for top with another more descriptive type (maybe IsTop). And in the definition of this type explain in detail what it means to be top

src/Juvix/Compiler/Concrete/Language.hs Outdated Show resolved Hide resolved
tests/Compilation/positive/test015.juvix Show resolved Hide resolved
@lukaszcz
Copy link
Collaborator Author

I'd be happy if we could replace the Bool argument for top with another more descriptive type (maybe IsTop). And in the definition of this type explain in detail what it means to be top

Done

@lukaszcz lukaszcz requested a review from janmasrovira May 15, 2024 17:19
@paulcadman paulcadman merged commit 161a34c into main May 22, 2024
4 checks passed
@paulcadman paulcadman deleted the case-syntax branch May 22, 2024 17:14
@lukaszcz lukaszcz mentioned this pull request Jun 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcadman paulcadman paulcadman approved these changes

@janmasrovira janmasrovira Awaiting requested review from janmasrovira

Assignees

@lukaszcz lukaszcz

Labels
enhancement New feature or request parsing prettyprinting syntax
Projects
None yet
Milestone
0.6.2
Development

Successfully merging this pull request may close these issues.

Make curly braces in case optional
3 participants
@lukaszcz @paulcadman @janmasrovira