-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add builtin ByteArray type #2933
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcadman
force-pushed
the
support-bytearray
branch
6 times, most recently
from
August 8, 2024 15:57
a35367c
to
fa068a3
Compare
janmasrovira
approved these changes
Aug 13, 2024
A check similar to CheckNoAnoma is added to check that programs in the Cairo and Asm backends do not contain ByteArray operations
This will be used to implement the List UInt8 -> ByteArray builtin in the Nockma backend
When we're evaluating `OpByteArrayFromListByte` we need to extract the list of bytes from the nexted list constructors that are passed to the Op. The polymorphic type of the list is passed in as the first argument to the constructor, so we remove it.
bytearray is not supported in Asm
This reverts changes made in 7fe81c4
Don't print BuiltinList as its now declared implicitly
paulcadman
force-pushed
the
support-bytearray
branch
from
August 13, 2024 09:24
dd977d6
to
940a073
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a builtin
ByteArray
type and associated functions for constructing aByteArray
from a list of bytes and a function to query the size of theByteArray
. It is only available in the Anoma backend.In Core / Tree, ByteArray constant is stored using a Haskell ByteString.
In Anoma the ByteArray is stored as a cell where the head is the length of the ByteArray and the tail is an integer is an integer formed by concatenating the bytes in the array using little-endian byte ordering.
The Nock for constructing a
ByteArray
uses thelength
,add
,folder
andlsh
functions from the Anoma hoon stdlib. See the code comment for more details.Example:
Output using
tests/Anoma/Compilation/positive/test082.juvix