-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register builtins during scoping and report proper errors instead of crashing #2943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmasrovira
changed the title
Register builtins during scoping
Register builtins during scoping and report proper errors instead of crashing
Aug 7, 2024
janmasrovira
force-pushed
the
register-builtins-scoping
branch
3 times, most recently
from
August 9, 2024 15:13
375269c
to
9ae71b6
Compare
janmasrovira
force-pushed
the
register-builtins-scoping
branch
from
August 12, 2024 17:54
9fb3bc3
to
c53f1cb
Compare
janmasrovira
force-pushed
the
register-builtins-scoping
branch
from
August 13, 2024 21:44
24aa98b
to
00a2638
Compare
Merged
paulcadman
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr has two relevant changes:
Errors instead of crases
When registering a builtin, we perform some sanity checks. When unsuccessful, the compiler crashes. This seldom happens because builtins are defined in libraries that we write ourselves. However, any compiler crash is a bug, so this pr refactors these crashes into proper errors.
Registering builtins during scoping
Before this pr, builtins are registered and sanity checked during the translation from Concrete to Internal. This imposes that the order in which we translate stuff is relevant, as we must register a builtin before we use it. For the most part this is fine when the dependency is explicit in the code, but sometimes there are explicit dependencies. E.g. do notation and the builtin
monad-bind
. In order to avoid adding special rules, it is easier to just register builtins during scoping, so I've refactored the code to do this.I've also removed the
Builtins
effect and moved its methods to theInfoTableBuilder
since the builtins table is now part of the Scoped InfoTable. Consequently, I've removed the the field_artifactBuiltins
.Future work