Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where highlighting is not kept when the file has a type error and imports some other file #2959

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented Aug 15, 2024

Example file:

module error;

import empty; -- error only happens if we have at least one import

type T := t;

x : T := t t; -- type error

If one loads this file into emacs (or vscode) they'll get a type error as expected, but name colors and go-to information is lost, which is annoying. This pr fixes this.
I'm not sure why, but this bug only occurs when there is at least one import.

@janmasrovira janmasrovira added fix:bug highlight Related to the `juvix internal highlight` command labels Aug 15, 2024
@janmasrovira janmasrovira self-assigned this Aug 15, 2024
@janmasrovira janmasrovira force-pushed the keep-highlight-on-error branch from 724f01a to 20af395 Compare August 21, 2024 10:03
@janmasrovira janmasrovira marked this pull request as ready for review August 21, 2024 10:03
@paulcadman paulcadman added this to the 0.6.6 milestone Aug 21, 2024
@janmasrovira janmasrovira merged commit 2b4520c into main Aug 21, 2024
5 of 8 checks passed
@janmasrovira janmasrovira deleted the keep-highlight-on-error branch August 21, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix:bug highlight Related to the `juvix internal highlight` command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants