Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IsInstanceCoercion to Internal #2981

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Add IsInstanceCoercion to Internal #2981

merged 1 commit into from
Sep 2, 2024

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented Aug 30, 2024 •
edited
Loading

We now use a sum type:

data IsInstanceCoercion
  = IsInstanceCoercionInstance
  | IsInstanceCoercionCoercion

instead of two mutually exclusive Bools.

Moreover, we properly print the keyword in the internal prettyprinter.

@janmasrovira janmasrovira self-assigned this Aug 30, 2024
@janmasrovira janmasrovira marked this pull request as ready for review August 30, 2024 11:22
@janmasrovira janmasrovira force-pushed the internal-IsInstanceCoercion branch from f72951c to fc55d8c Compare August 30, 2024 13:07
@lukaszcz lukaszcz force-pushed the internal-IsInstanceCoercion branch from fc55d8c to a5fa682 Compare September 2, 2024 08:08
@lukaszcz lukaszcz merged commit 9d2a2b5 into main Sep 2, 2024
4 checks passed
@lukaszcz lukaszcz deleted the internal-IsInstanceCoercion branch September 2, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszcz lukaszcz lukaszcz approved these changes

@paulcadman paulcadman Awaiting requested review from paulcadman

Assignees

@janmasrovira janmasrovira

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janmasrovira @lukaszcz