Compilation of side conditions in pattern matches #2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszcz
force-pushed
the
matching-side-conditions
branch
3 times, most recently
from
b26f4a0 to
f904923
Compare
lukaszcz
force-pushed
the
matching-side-conditions
branch
from
08403ad to
96947e8
Compare
lukaszcz
requested review from
janmasrovira and
paulcadman
and removed request for
janmasrovira
lukaszcz
force-pushed
the
matching-side-conditions
branch
2 times, most recently
from
e09511d to
6596393
Compare
|
As discussed, let's first merge the removal of |
janmasrovira
force-pushed
the
matching-side-conditions
branch
from
6596393 to
649be19
Compare
janmasrovira
approved these changes
Sep 9, 2024
lukaszcz
force-pushed
the
matching-side-conditions
branch
from
649be19 to
9b6f05a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matchnodes in Core. Updates Core parsing, printing and the evaluator.elsebranch are allowed in Core. If there is anelsebranch, the side conditions are translated infromInternalinto nested ifs. Because withelsethe conditions are exhaustive, there are no implications for pattern exhaustiveness checking.