Add frontend support for Anoma stdlib sha256 #3109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions like integerToByteString did not terminate when called with negative integers. For Nockma we only need to encode Natural numbers so this commit restricts the integer encoding functions to work only with natural numbers.
The new builtin can be declared as follows:
```
builtin anoma-sha256
axiom anomaSha256 : Nat -> ByteArray;
```
The intention is that it wraps a call to anomaEncode as follows:
sha256 {A} (a : A) : ByteArray := anomaSha256 (anomaEncode a);
lukaszcz
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds frontend support for Anoma stdlib sha256 function (aka
shaxin Nock).The new builtin can be declared as follows:
The intention is that it wraps a call to anomaEncode as follows:
Fix for atom to ByteString
This PR also includes a commit 6205dc9 to fix an issue with functions like
integerToByteArraywhen called with negative integers (the solution is to change the argument types to Natural, as this is all we need for Anoma).