Fix compiler error on import cycles #3171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmasrovira
changed the title
janmasrovira
force-pushed
the
3161-weird-compiler-error-on-import-cycles
branch
2 times, most recently
from
2a56e3b to
a858692
Compare
|
Is it possible to add a test, perhaps based on the example in the bug report, that is fixed by this PR? |
|
It took me a while but I finally pruned it down to a (local) minimal test. I say local because removing any single file results in the crash not showing, but there might be another way of organizing files that results in a smaller test. |
paulcadman
previously approved these changes
Nov 14, 2024
janmasrovira
force-pushed
the
3161-weird-compiler-error-on-import-cycles
branch
from
221862e to
2c30118
Compare
paulcadman
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strongly connected components given in this function are not guaranteed to give a cycle in the order they are given. I've fixed that