Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node scanning for ImportTree #3251

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented Dec 19, 2024

The crash occurred because the ImportTree was built incorrectly. In particular, some nodes were scanned with an incorrect resolver root.

@janmasrovira janmasrovira added this to the 0.6.10 milestone Dec 19, 2024
@janmasrovira janmasrovira self-assigned this Dec 19, 2024
@janmasrovira janmasrovira linked an issue Dec 19, 2024 that may be closed by this pull request
@janmasrovira janmasrovira force-pushed the 3244-parallel-compilation-is-buggy branch from 1aa5cae to 9d9122a Compare December 19, 2024 01:29
@janmasrovira janmasrovira changed the title Fix Fix node scanning for ImporTree Dec 19, 2024
@janmasrovira janmasrovira marked this pull request as ready for review December 19, 2024 02:40
@lukaszcz lukaszcz force-pushed the 3244-parallel-compilation-is-buggy branch from 9d9122a to d194ac1 Compare December 19, 2024 08:37
@lukaszcz lukaszcz changed the title Fix node scanning for ImporTree Fix node scanning for ImportTree Dec 19, 2024
@lukaszcz lukaszcz self-requested a review December 19, 2024 11:04
@lukaszcz lukaszcz merged commit 4dcbf79 into main Dec 19, 2024
4 checks passed
@lukaszcz lukaszcz deleted the 3244-parallel-compilation-is-buggy branch December 19, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallel compilation is buggy
2 participants