Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move disposable-gas-payer arg #3424

Closed
grarco opened this issue Jun 18, 2024 · 0 comments · Fixed by #3699
Closed

Move disposable-gas-payer arg #3424

grarco opened this issue Jun 18, 2024 · 0 comments · Fixed by #3699
Assignees
@grarco
Labels
client gas prio:low SDK
Milestone
Nice to have and ...

Comments

@grarco
Copy link
Contributor

grarco commented Jun 18, 2024 •
edited
Loading

Currently the --disposable-gas-payer arg lives under the Tx args. Just a subset of transactions though can actually utilize this arg: we should therefore move it out of Tx and make it a custom argument for a set of specific transactions, namely:

  • ShieldedTransfer
  • UnshieldingTransfer
  • IBCTransfer

We also need to rework aux_signing_data to request this extra optional argument
@grarco grarco changed the title Move disposable-gas-payerargs Move disposable-gas-payer arg Aug 20, 2024
@grarco grarco self-assigned this Aug 23, 2024
@grarco grarco mentioned this issue Aug 23, 2024
Merged
1 task
@mergify mergify bot closed this as completed in #3699 Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grarco grarco

Labels
client gas prio:low SDK
Projects
None yet
Milestone
Nice to have and non-breaking
Development

Successfully merging a pull request may close this issue.

Update disposable signer anoma/namada
2 participants
@cwgoes @grarco