-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update disposable signer #3699
Update disposable signer #3699
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3699 +/- ##
==========================================
- Coverage 61.17% 61.16% -0.02%
==========================================
Files 315 315
Lines 103187 103220 +33
==========================================
+ Hits 63129 63131 +2
- Misses 40058 40089 +31 ☔ View full report in Codecov by Sentry. |
a05d0a5
to
8ec7bbe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed some spelling, otherwise LGTM!
Describe your changes
Closes #3424.
Removes the
disposable-gas-payer
arg from the generalTx
args and makes it specific to a set of transactions:TxShieldedTransfer
TxUnshieldingTransfer
TxIbc
TxCustom
SignTx
struct used to sign transactions offlineChecklist before merging
breaking::
labels