Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync write-log and storage prefix iterator ordering #1141

Merged
merged 5 commits into from
Mar 13, 2023

Conversation

brentstone
Copy link
Collaborator

@brentstone brentstone commented Feb 9, 2023

Fixes a bug wherein the prefix iterator ordering was different between the write-log and the storage, resulting in erroneous behavior in the WlStorage.

Closes #1136.

@brentstone
Copy link
Collaborator Author

pls update wasm

brentstone added a commit that referenced this pull request Feb 15, 2023
tzemanovic pushed a commit that referenced this pull request Feb 22, 2023
@tzemanovic tzemanovic force-pushed the tomas+brent/fix-wl-storage-prefix-iter-ordering branch from 2eb778b to 7be619c Compare February 22, 2023 08:18
@tzemanovic tzemanovic force-pushed the tomas+brent/fix-wl-storage-prefix-iter-ordering branch from 7be619c to 081490c Compare February 22, 2023 09:05
@tzemanovic
Copy link
Member

pls update wasm

sug0 added a commit that referenced this pull request Mar 1, 2023
test/core/wl_storage: add test for `prefix_iter_pre`/`prefix_iter_post`

bug fix: reliable deterministic ordering of keys in wl_storage PrefixIter that fixes apply_inflation bug

changelog: add #1141

test/storage: reduce arb key length
@brentstone brentstone closed this Mar 9, 2023
@brentstone brentstone deleted the tomas+brent/fix-wl-storage-prefix-iter-ordering branch March 9, 2023 20:32
@brentstone brentstone restored the tomas+brent/fix-wl-storage-prefix-iter-ordering branch March 9, 2023 20:33
@brentstone brentstone reopened this Mar 9, 2023
juped added a commit that referenced this pull request Mar 13, 2023
* tag 'v0.14.2':
  Namada 0.14.2
  changelog: add #1191
  test/pos/sm: fix init-validator and bond pre-conditions
  [ci] wasm checksums update
  ci: use nightly version for e2e test
  test/pos/sm: add the rest of the conditions
  pos: improve withdrawal logs
  test/pos/sm: add another bonds post-cond
  test/pos/sm: generate InitValidator transitions
  test/pos: fix the bonds test
  test/pos: reduce the bond token amounts to cover cases with same amounts
  bug fix: `update_validator_set` precisely checks if validator in consensus set
  pos: remove the `init` function to just use `set` instead
  make: add unstable-options to `check-abcipp` recipe
  pos: turn prints into tracing::debug, tidy up code
  pos/epoched: fix the update_data logic
  test/pos: add a state machine test
  test/core/address: fix address generator to be deterministic
  core/token: re-export `token::Change` type from storage_api mod
  make: use unstable-options to build unit tests
  changelog: add #1197
  [ci] wasm checksums update
  pos: ensure that validator consensus keys are unique
  core/storage: impl KeySeg for common::PublicKey
  test/lazy_set: add `try_insert` to state machine test
  core/lazy_set: add `try_insert` method
  small documentation edits
  changelog: add #1196
  [ci] wasm checksums update
  test: add a state machine test for lazy set collection
  core/storage_api: add LazySet
  changelog: #1182
  test/e2e: wait for a first block before client cmds
  wl_storage: remove commit_genesis method
  test/e2e: put ledger to bg to avoid it getting stuck
  gov/parameters: init via storage_api write log
  parameters: init chain parameters via storage_api write log
  init-chain: fix ibc to go via wl_storage
  [chore]:Added a doc warning
  [feat]: Dont' persist storage changes at genesis
  test/init_chain: ensure that init-chain doesn't commit to DB
  test/storage: reduce arb key length
  [ci] wasm checksums update
  changelog: add #1141
  bug fix: reliable deterministic ordering of keys in wl_storage PrefixIter that fixes apply_inflation bug
  test/core/wl_storage: add test for `prefix_iter_pre`/`prefix_iter_post`
@juped juped merged commit c8b17ca into main Mar 13, 2023
@juped juped deleted the tomas+brent/fix-wl-storage-prefix-iter-ordering branch March 13, 2023 21:34
bengtlofgren pushed a commit that referenced this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

write-log prefix iter is not ordered
3 participants