Fix slashable stake in slash processing #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentstone
force-pushed
the
brent/fix-sum-post-bonds-slashing
branch
from
7e76927
to
dad87f0
Compare
|
Need to also change this implementation in the AbstractState of the state machine test |
brentstone
force-pushed
the
brent/fix-sum-post-bonds-slashing
branch
from
4ec81e2
to
8a40a31
Compare
brentstone
force-pushed
the
brent/fix-sum-post-bonds-slashing
branch
from
8a40a31
to
56a2f63
Compare
tzemanovic
reviewed
Jun 12, 2023
tzemanovic
reviewed
Jun 12, 2023
tzemanovic
force-pushed
the
brent/fix-sum-post-bonds-slashing
branch
from
7b4e333
to
55d6390
Compare
|
pls update wasm |
tzemanovic
added a commit
that referenced
this pull request
Jun 12, 2023
* brent/fix-sum-post-bonds-slashing: [ci] wasm checksums update changelog: #1520 pos state machine: fix slashing computation simplify some code to a `max` function mute `total_slashed` for now fix calculation with `sum_post_bonds`
Closed
Fraccaman
added a commit
that referenced
this pull request
Jun 14, 2023
* origin/brent/fix-sum-post-bonds-slashing: [ci] wasm checksums update changelog: #1520 pos state machine: fix slashing computation simplify some code to a `max` function mute `total_slashed` for now fix calculation with `sum_post_bonds`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on v0.17.0.
In the procedure for processing slashes, we must compute the slashable stake for an epoch at or ahead of the current epoch in the presence of bonds that began contributing to stake after the infraction epoch. A slight change is needed to fix buggy behavior in the existing implementation of this computation. See the following discussion for more details: informalsystems/partnership-heliax#55 (comment).