Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multisignature #1777

Merged
merged 14 commits into from
Aug 14, 2023
Merged

Multisignature #1777

merged 14 commits into from
Aug 14, 2023

Conversation

Fraccaman
Copy link
Member

@Fraccaman Fraccaman commented Jul 29, 2023

Describe your changes

  • Convert all accounts to be multisignature account
  • Added corresponding methods/argument in the cli/sdk to create/modify multisignature accounts
  • Added methods to serialize a tx
  • Added methods to offline sign a tx and serialize the signature
  • Added methods to add a serialized signatures to a tx

Indicate on which release or other PRs this topic is based on

0.20.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@bengtlofgren
Copy link
Contributor

2 things that I could see:

  1. namadac query-account unwraps on None if no --owner is provided
  2. namadac query-proposal with --help provides a bunch of arguments that are not helpful in this context, things like --dry-run and --signing-keys

juped added a commit that referenced this pull request Aug 9, 2023
…e' (#1777) into main

* namada/fraccaman/multisignature-complete:
  added cli command sign-tx, added a way to attach offline signatures to a transaction
  Updated test vector generator.
  fix: removed --mode from generator.sh
  fix: gas and fee payer cli, reveal pk
  added changelog
  fix: e2e test
  fix: unit test
  wasm: added new account methods to tx_prelude, refactor signature verification, rebuild wasm_for_tests
  docs: update tx definitions
  apps,shared: added cli tx and query methods
  core: added multisignature tx format, refacctor account storage api, added max_signature_per_transaction genesis parameter
@Fraccaman Fraccaman mentioned this pull request Aug 10, 2023
2 tasks
@murisi murisi mentioned this pull request Aug 11, 2023
2 tasks
@Fraccaman Fraccaman merged commit d0f5c8c into main Aug 14, 2023
10 of 12 checks passed
@Fraccaman Fraccaman deleted the fraccaman/multisignature-complete branch August 14, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants