Call Message::parse directly
#1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tzemanovic
approved these changes
Aug 29, 2023
sug0
added a commit
that referenced
this pull request
Aug 30, 2023
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/tiago/call-msg-parse: Changelog for #1849 Call `Message::parse` directly
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/tiago/call-msg-parse: Changelog for #1849 Call `Message::parse` directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
When calling into
libsecp256k1functions, we do not need to attempt to parse message digests. This is because we have a[u8; 32]value ready to be passed to the library code.Indicate on which release or other PRs this topic is based on
v0.21.1Checklist before merging to
draft