Makes async traits in the SDK be Send
#1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mariari
previously approved these changes
Sep 14, 2023
sug0
reviewed
Sep 14, 2023
There was a problem hiding this comment.
I think this will be a problem for the namada interface; see rustwasm/wasm-bindgen#2833
We can gate the ability to send futures across threads with something like:
#[cfg_attr(not(feature = "send-sdk-client"), async_trait(?Send))]
#[cfg_attr(feature = "send-sdk-client", async_trait)]
trait Client { ... }
grarco
force-pushed
the
grarco/sdk-async-traits-send
branch
from
12b2cf8
to
d89c660
Compare
grarco
added a commit
that referenced
this pull request
Sep 21, 2023
Fraccaman
added a commit
that referenced
this pull request
Sep 25, 2023
* origin/grarco/sdk-async-traits-send: changelog: add #1894 Conditionally requires async traits `Send`ness Makes async traits in the SDK be `Send`
Fraccaman
added a commit
that referenced
this pull request
Sep 25, 2023
…rarco/sdk-async-traits-send: changelog: add #1894 Conditionally requires async traits `Send`ness Makes async traits in the SDK be `Send`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Requires the
Sendbound on theasync_traitss in the SDK. This allow the usage of the SDK in an environment which is both async and multithread (see https://rust-lang.github.io/async-book/07_workarounds/03_send_approximation.html).Indicate on which release or other PRs this topic is based on
v0.22.0
Checklist before merging to
draft