Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Hardware Wallet Support in CLI #2209

Merged
merged 8 commits into from
Dec 7, 2023
Merged

Conversation

murisi
Copy link
Contributor

@murisi murisi commented Nov 22, 2023

Describe your changes

Increased the CLIs support for the hardware wallet. Specifically made the following changes:

  • Reduced the assumption that we always possess the secret key in the client by changing the secret key CLI arguments into public key arguments
    • In some cases, the secret key is eventually looked up from the software wallet using the public key in the command line arguments
    • In other cases, the secret key is never required since the entire transaction is sent to the hardware wallet for signing there
  • Removed the --verification-key CLI argument since --signing-keys, which now takes public keys instead of secret keys, can be used instead to the same effect
  • Transactions are now contracted before being sent to the hardware wallet. This is necessary because some transactions were previously too large for the hardware wallet
  • Made the FindKeyError::KeyNotFound more informative by embedding the alias that was not found inside it
  • Corrected an issue with sign_raw where a non-contiguous public keys map would cause a panic in the case that no signer is supplied
  • Ensured that extend_from_pre_genesis_validator also adds the public keys corresponding to the secret keys in the ValidatorWallet to the Store.

Indicate on which release or other PRs this topic is based on

Namada v0.27.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

…de. Corrected extend_from_pre_genesis_validator to also extend public keys.
@murisi murisi marked this pull request as ready for review November 28, 2023 07:04
@murisi murisi requested a review from cwgoes November 29, 2023 13:00
Fraccaman
Fraccaman previously approved these changes Nov 30, 2023
@tzemanovic tzemanovic merged commit b1d5c9b into main Dec 7, 2023
12 of 14 checks passed
@tzemanovic tzemanovic deleted the murisi/cli-public-keys branch December 7, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants