-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase Hardware Wallet Support in CLI #2209
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… wallet signing is not precluded.
murisi
force-pushed
the
murisi/cli-public-keys
branch
from
November 22, 2023 15:02
158e6b7
to
966afb5
Compare
… the signing keys argument.
…de. Corrected extend_from_pre_genesis_validator to also extend public keys.
murisi
force-pushed
the
murisi/cli-public-keys
branch
from
November 24, 2023 06:12
8664d5d
to
6974b5d
Compare
murisi
force-pushed
the
murisi/cli-public-keys
branch
from
November 28, 2023 07:36
e6c53b1
to
a1b2d09
Compare
Fraccaman
previously approved these changes
Nov 30, 2023
murisi
added a commit
that referenced
this pull request
Nov 30, 2023
This was referenced Nov 30, 2023
Closed
batconjurer
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Increased the CLIs support for the hardware wallet. Specifically made the following changes:
--verification-key
CLI argument since--signing-keys
, which now takes public keys instead of secret keys, can be used instead to the same effectFindKeyError::KeyNotFound
more informative by embedding the alias that was not found inside itsign_raw
where a non-contiguous public keys map would cause a panic in the case that nosigner
is suppliedextend_from_pre_genesis_validator
also adds the public keys corresponding to the secret keys in theValidatorWallet
to theStore
.Indicate on which release or other PRs this topic is based on
Namada v0.27.0
Checklist before merging to
draft