Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable rocksdb jemalloc only for make build-release #2404

Closed
wants to merge 2 commits into from
Closed

enable rocksdb jemalloc only for make build-release #2404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
981741b
enable rocksdb jemalloc only for `make build-release`
tzemanovic Jan 16, 2024
b60f915
changelog: add #2404
tzemanovic Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changelog/unreleased/improvements/2404-opt-jemalloc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Disabled RocksDB jemalloc feature by default.
([\#2404](https://github.com/anoma/namada/pull/2404))
11 changes: 0 additions & 11 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ build-test:
$(cargo) +$(nightly) build --tests $(jobs)

build-release:
$(cargo) build $(jobs) --release --timings --package namada_apps --manifest-path Cargo.toml
$(cargo) build $(jobs) --release --timings --package namada_apps \
--manifest-path Cargo.toml \
--features jemalloc

build-debug:
$(cargo) build --package namada_apps --manifest-path Cargo.toml
Expand Down
13 changes: 7 additions & 6 deletions apps/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,12 @@ testing = ["namada_test_utils"]
benches = ["testing", "namada_test_utils"]
integration = []

# RocksDB's "jemalloc" disabled by default as it takes a long time to build.
# Enabled in `make build-release`.
[target.'cfg(not(windows))'.features]
jemalloc = ["rocksdb/jemalloc"]
[target.'cfg(windows)'.features]
jemalloc = [] # jemalloc is not supported on windows

[dependencies]
namada = {path = "../shared", features = ["multicore", "http-client", "tendermint-rpc"]}
Expand Down Expand Up @@ -116,6 +122,7 @@ regex.workspace = true
reqwest.workspace = true
ripemd.workspace = true
rlimit.workspace = true
rocksdb = { workspace = true }
rpassword.workspace = true
serde_bytes.workspace = true
serde_json = {workspace = true, features = ["raw_value"]}
Expand All @@ -141,12 +148,6 @@ zeroize.workspace = true
warp = "0.3.2"
bytes = "1.1.0"

[target.'cfg(not(windows))'.dependencies]
rocksdb = { workspace = true, features = ['jemalloc'] } # jemalloc is not supported on windows

[target.'cfg(windows)'.dependencies]
rocksdb = { workspace = true }

[dev-dependencies]
assert_matches = "1.5.0"
namada = {path = "../shared", default-features = false, features = ["testing", "wasm-runtime"]}
Expand Down
Loading