Integrate ZIP32 functionality for MASP keys #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
karbyshev
force-pushed
the
aleks/wallet-zip32-0.30.1
branch
from
8ec5e7f
to
a7440f6
Compare
Closed
tzemanovic
reviewed
Jan 22, 2024
tzemanovic
previously approved these changes
Jan 22, 2024
tzemanovic
added a commit
that referenced
this pull request
Jan 22, 2024
* origin/aleks/wallet-zip32-0.30.1: Minor refactoring of wallet e2e Add changelog Introduce flag to allow non-compliant derivation paths Fix comment Derivation path compliancy checks Fix e2e test cases Simplify some SDK interfaces Store derivation path when adding zip32 key Fix return code Derive and store maps spending key in the wallet Refactor: rename function Implement zip32 key generation in wallet Add doc comment Rename key gen error struct Fix zip32 import Add derivation paths for zip32 Refactor: rename derivation path methods Purpose constant Fix: undo erroneous changes in wallet introduced in 0.28.0 rc1
2 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR features the following changes:
Additionally, the PR undoes some erroneous changes in wallet introduced in 0.28.0 rc1
The PR is based on v0.30.1