Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update speculative shielded context only when required #2775

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

grarco
Copy link
Contributor

@grarco grarco commented Feb 29, 2024

Describe your changes

Closes #2750.

Fixed a bug for which the speculative shielded context was updated even when dry running a transaction.

Indicate on which release or other PRs this topic is based on

v0.31.8

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 53.95%. Comparing base (2535c9c) to head (dc14669).

Files Patch % Lines
crates/sdk/src/masp.rs 0.00% 9 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 5 Missing ⚠️
crates/apps/src/lib/bench_utils.rs 0.00% 1 Missing ⚠️
crates/sdk/src/signing.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2775      +/-   ##
==========================================
- Coverage   53.95%   53.95%   -0.01%     
==========================================
  Files         308      308              
  Lines      100018   100024       +6     
==========================================
- Hits        53967    53965       -2     
- Misses      46051    46059       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grarco grarco marked this pull request as ready for review February 29, 2024 12:07
Fraccaman pushed a commit to Fraccaman/namada that referenced this pull request Mar 1, 2024
* upstream/0.31.9-rc2:
  Namada 0.31.9
  changelog: add anoma#2748
  fix redelegation log
  fix some client logging for forced txs
  fix query_withdrawable_tokens
  fix spelling
  prohibit cross-validator bonding in client
  added changelog
  added changelog
  disable default features for git2
  update rocksdb to 0.22.0
  Changelog anoma#2775
  Updates speculative shielded context only when required
  add changelog
  fix timeout timestamp for PGF over IBC
  wait another epoch
  add changelog
  fix pgf over ibc test
@tzemanovic tzemanovic merged commit 99473b4 into main Mar 7, 2024
15 of 17 checks passed
@tzemanovic tzemanovic deleted the grarco/fix-shielded-context-dry-run branch March 7, 2024 17:25
Fraccaman pushed a commit that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No balance found after a dry-run shielded IBC with disposable gas payer
3 participants