restore the IBC tx gas cost to match v0.31.6 #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
added a commit
that referenced
this pull request
Mar 6, 2024
tzemanovic
added a commit
that referenced
this pull request
Mar 6, 2024
tzemanovic
force-pushed
the
tomas/restore-ibc-tx-gas-cost
branch
from
5435a47
to
c02f6b2
Compare
tzemanovic
added a commit
that referenced
this pull request
Mar 6, 2024
* origin/tomas/restore-ibc-tx-gas-cost: changelog: add #2824 ibx/tx: restore previous `fn iter_next` impl ibc/tx: charge gas for IBC events
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2824 +/- ##
==========================================
- Coverage 53.95% 53.90% -0.06%
==========================================
Files 308 308
Lines 100018 100120 +102
==========================================
+ Hits 53967 53969 +2
- Misses 46051 46151 +100 ☔ View full report in Codecov by Sentry. |
tzemanovic
force-pushed
the
tomas/restore-ibc-tx-gas-cost
branch
from
c02f6b2
to
61efb3a
Compare
tzemanovic
added a commit
that referenced
this pull request
Mar 6, 2024
* tomas/restore-ibc-tx-gas-cost: changelog: add #2824 ibx/tx: restore previous `fn iter_next` impl
Fraccaman
pushed a commit
that referenced
this pull request
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR restores the original IBC tx gas cost that was accidentally changed in v0.31.7 (in #2486).
The
iter_nextcan be simplified with a cheaper gas cost again in a breaking release (#2827)Indicate on which release or other PRs this topic is based on
v0.31.8
Checklist before merging to
draft