Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mint and burn prelude functions #3109

Merged
merged 4 commits into from
Apr 27, 2024
Merged

Conversation

Fraccaman
Copy link
Member

@Fraccaman Fraccaman commented Apr 23, 2024

Describe your changes

Reusing the burn and credit functions from the token crate. Closes #2287

Indicate on which release or other PRs this topic is based on

v0.33.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 59.40%. Comparing base (0da7c4a) to head (541c0ad).

Files Patch % Lines
crates/apps/src/lib/bench_utils.rs 0.00% 4 Missing ⚠️
crates/tx_prelude/src/token.rs 78.94% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3109   +/-   ##
=======================================
  Coverage   59.40%   59.40%           
=======================================
  Files         298      298           
  Lines       92771    92730   -41     
=======================================
- Hits        55108    55087   -21     
+ Misses      37663    37643   -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Gianmarco Fraccaroli added 2 commits April 24, 2024 11:29
tzemanovic
tzemanovic previously approved these changes Apr 24, 2024
@brentstone brentstone mentioned this pull request Apr 24, 2024
brentstone added a commit that referenced this pull request Apr 24, 2024
* fraccaman/refactor-transfer-code:
  changelog: add #3109
  fix benches
  fmt, clippy
  fix mint and burn prelude functions
  ci: fix antithesis workflow
  ci: added triggerable antithesis workflow
  ci: downgrade sccache to 0.7.7
brentstone added a commit that referenced this pull request Apr 24, 2024
* fraccaman/refactor-transfer-code:
  changelog: add #3109
  fix benches
  fmt, clippy
  fix mint and burn prelude functions
  ci: fix antithesis workflow
  ci: added triggerable antithesis workflow
  ci: downgrade sccache to 0.7.7
@brentstone brentstone merged commit 8b4a85a into main Apr 27, 2024
18 of 19 checks passed
@brentstone brentstone deleted the fraccaman/refactor-transfer-code branch April 27, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace ad-hoc token transfer code with storage API code
4 participants